-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wording of uninitialized value error to be grammatically correct #14292
Update wording of uninitialized value error to be grammatically correct #14292
Conversation
While you are in the neighborhood, it is ungrammatical to hyphenate
Here, I also took the liberty of upgrading "may" to "can". "May" implies mere permission, and also means "maybe", as in, "only initialized values might [turn out to] be used as arguments." I wonder if I can find the "fully operational death star" meme. |
I disagree with this interpretation. The word "may" in this context is common to denote permission specifically rather than possibility. Nothing wrong with using "can" though, so I'm not against it. I do personally prefer "may" for how it sounds, but both work fine imo. |
I see what you mean. I would be open to changing that in a separate PR, but I would want to check with @liufengyun about that change. In this context, I believe the term might be hyphenated due to it referring specifically to the value being Hot as defined here as opposed to a less specific definition of "fully initialized" . |
By all means, stick with your gut feeling. "May" is fine. Also fine weather in May. It's interesting that you understand hyphenation to have additional semantics. Obviously "American Swiss" is the cheese and "Swiss-American" is the immigrant or holder of dual passports. The advantage of changing it now is just, so long as you're updating the check files for tests. |
LGTM when there are fewer failures, I hope they agree. FYI, I think they also accept |
I think it's fine to change it to |
649c142
to
8d4ff69
Compare
- Instead of "May only use initialized value as arguments." it now says "Only initialized values may be used as arguments." Review by @liufengyun
6725cf3
to
726f0a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…zed" - Remove hyphen from error message (as mentioned [here](scala#14292 (comment))) Signed the CLA - @Xavientois Review by @liufengyun
…zed" - Remove hyphen from error message (as mentioned [here](scala#14292 (comment))) Signed the CLA - @Xavientois Review by @liufengyun
…zed" - Remove hyphen from error message (as mentioned [here](scala#14292 (comment))) Signed the CLA - @Xavientois Review by @liufengyun
Update wording of uninitialized value error to be grammatically correct.
Instead of "May only use initialized value as arguments." it now says "Only initialized values may be used as arguments."
In theory, this should improve readability of error messages such as:
Signed the CLA - @Xavientois
Review by @liufengyun