Fix erased context function types, 2nd attempt #13736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Otherwise LGTM |
| def erasedName = | ||
| if ref.is(Flags.Method) | ||
| && contextResultsAreErased(ref.symbol) | ||
| && (ref.owner.is(Flags.Trait) || ref.symbol.allOverriddenSymbols.hasNext) |
There was a problem hiding this comment.
Apart from breaking binary compatibility is there another reason not to name all contex function dirrect accessors with $direct? It seems that nameing all these methods with $direct would also solve some of the other overloading issues.
There was a problem hiding this comment.
Name mangling is always bad because it confuses tack traces and (in this case) causes more indirection via bridge methods, which blows up code sizes. So I'd avoid it if we don't absolutely need it.
Add a `$` to the name of a method that has erased context results and that may override some other method. This is to prevent the two methods from having the same names and parameters in their erased signatures. We need a bridge between the two methods, so they are not allowed to already override after erasure.
Use "$direct" instead of just "$" to prevent erasure clashes of methods with erased context function results.
nicolasstucki
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
$to the name of a method that has erased context results and thatmay override some other method. This is to prevent the two methods from having
the same names and parameters in their erased signatures. We need a bridge between the
two methods, so they are not allowed to already override after erasure.