Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

feat: Add ping api for health checks #38

Merged
merged 2 commits into from
Jul 14, 2021
Merged

feat: Add ping api for health checks #38

merged 2 commits into from
Jul 14, 2021

Conversation

Taewan-P
Copy link
Contributor

This PR adds a ping API to webserver for health checks.
Endpoint: GET /func/ping

Internal ticket: OP#1416

@CLAassistant
Copy link

CLAassistant commented Jul 14, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #38 (7b51974) into main (92a85f0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files           2        2           
  Lines          32       32           
=======================================
  Hits           31       31           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a85f0...7b51974. Read the comment docs.

Copy link
Member

@inureyes inureyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inureyes inureyes merged commit 63ca386 into lablup:main Jul 14, 2021
inureyes pushed a commit that referenced this pull request Jul 14, 2021
* feat: Add ping api for health checks

* Add news fragment
inureyes pushed a commit that referenced this pull request Jul 14, 2021
* feat: Add ping api for health checks

* Add news fragment
@inureyes inureyes added this to the 21.03 milestone Sep 23, 2021
@inureyes inureyes added enhancement New feature or request good first issue Good for newcomers labels Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants