Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

feature: rename console server to webserver #32

Merged
merged 4 commits into from
Mar 8, 2021

Conversation

lizable
Copy link
Contributor

@lizable lizable commented Feb 26, 2021

This PR updates the name console-server to webserver for better understanding.

@lizable lizable added the enhancement New feature or request label Feb 26, 2021
@lizable lizable added this to the 20.03 milestone Feb 26, 2021
@lizable lizable requested review from achimnol and adrysn February 26, 2021 05:10
@lizable lizable self-assigned this Feb 26, 2021
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@f49adde). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage        ?   96.87%           
=======================================
  Files           ?        2           
  Lines           ?       32           
  Branches        ?        0           
=======================================
  Hits            ?       31           
  Misses          ?        1           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f49adde...6a7d726. Read the comment docs.

README.md Outdated
@@ -7,7 +7,7 @@ A minimal webapp to convert web session requests to API requests.

Prepare a Python virtualenv (Python 3.7 or higher) and a Redis server (5.0 or higher).

```console
```webserver
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is markdown console prefix so it need to be kept.

@lizable lizable requested a review from inureyes February 26, 2021 06:31
Copy link
Member

@inureyes inureyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inureyes inureyes merged commit 72385b2 into main Mar 8, 2021
@inureyes inureyes deleted the feature/rename-console-server-to-webserver branch March 8, 2021 09:20
inureyes pushed a commit that referenced this pull request Mar 8, 2021
* update: rename console-server to webserver

* add: history fragment for change

* fix: omitted name changes

* fix: typo and update server module path to valid
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants