Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No valid notebook detected #190

Closed
Koncopd opened this issue Feb 4, 2024 · 4 comments
Closed

No valid notebook detected #190

Koncopd opened this issue Feb 4, 2024 · 4 comments
Assignees
@kynan
Labels
resolution:fixed type:bug type:regression
Milestone
0.7.1

Comments

@Koncopd
Copy link

Koncopd commented Feb 4, 2024 •
edited
Loading

I get No valid notebook detected on nbstripout of all my notebooks with nbstripout 0.7.0
I use jupyter notebook 6.4.11

Is it not compatible anymore?
@Koncopd Koncopd mentioned this issue Feb 4, 2024
Closed
@Koncopd
Copy link
Author

Koncopd commented Feb 4, 2024

test-notebook.json
Example notebook where it fails, changed the file type to be able to attach.

@Koncopd Koncopd mentioned this issue Feb 4, 2024
Open
@kynan kynan self-assigned this Feb 4, 2024
@kynan
Copy link
Owner

kynan commented Feb 4, 2024

Thanks for reporting. I can reproduce the issue. That's a major regression, sorry for not catching this!

I'll release 0.7.1 with a fix shortly and will yank 0.7.0 from PyPI.

@kynan kynan added this to the 0.7.1 milestone Feb 4, 2024
@Koncopd
Copy link
Author

Koncopd commented Feb 4, 2024

Thank you.

@kynan kynan closed this as completed in cb98ba9 Feb 4, 2024
@kynan
Copy link
Owner

kynan commented Feb 4, 2024

@Koncopd Release is out, can you please verify?

@kynan kynan mentioned this issue Feb 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kynan kynan

Labels
resolution:fixed type:bug type:regression
Projects
None yet
Milestone
0.7.1
Development

No branches or pull requests
2 participants
@kynan @Koncopd