Skip to content

Commit ff035e4

Browse files
committed
Covered test case for GenMaskForFloat when target is integer. Fixed typo in variable name.
1 parent 043e246 commit ff035e4

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

lexer.go

+7-5
Original file line numberDiff line numberDiff line change
@@ -247,20 +247,22 @@ func (l *Lexer) GenMaskForFloat(target, source string) (mask []bool) {
247247

248248
mask = l.GenMaskForInt(targetWhole, sourceWhole)
249249

250+
if targetWhole == target {
251+
return
252+
}
253+
250254
// dot is never colored
251255
mask = append(mask, false)
252256

253-
tragetFracStart := strings.IndexRune(target, '.') + 1
254-
if tragetFracStart == 0 {
255-
tragetFracStart = len(target)
256-
}
257+
// This one is never 0, because of the if up there that returns
258+
targetFracStart := strings.IndexRune(target, '.') + 1
257259

258260
sourceFracStart := strings.IndexRune(source, '.') + 1
259261
if sourceFracStart == 0 {
260262
sourceFracStart = len(source)
261263
}
262264

263-
targetFrac := target[tragetFracStart:]
265+
targetFrac := target[targetFracStart:]
264266
sourceFrac := source[sourceFracStart:]
265267

266268
if len(targetFrac) > len(sourceFrac) {

lexer_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -318,6 +318,7 @@ func TestGenMaskForFloat(t *testing.T) {
318318
{"1.24", "2", []bool{true, false, true, true}},
319319
{"1.24", "2", []bool{true, false, true, true}},
320320
{"2.", "2", []bool{false, false}},
321+
{"2", "2.", []bool{false}},
321322
{"2.", "2.2", []bool{false, false}},
322323
{"2.2", "2.", []bool{false, false, true}},
323324
{".5", "2.5", []bool{false, false}},

0 commit comments

Comments
 (0)