Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-3619: fix typo in the feature blog to be published on 2024-08-22 #47500

Conversation

everpeace
Copy link
Contributor

Description

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 14, 2024
@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Aug 14, 2024
@k8s-ci-robot k8s-ci-robot requested a review from sftim August 14, 2024 12:39
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Aug 14, 2024
Copy link
Contributor Author

@everpeace everpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim @natalisucks @mbianchidev

I found a typo in my feature blog. Could you kindly review this tiny fix PR??? 🙇🙇 This feature blog is planned to be published on 2024-08-22.

Copy link

netlify bot commented Aug 14, 2024

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit fa2365b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66bca56d79b9280008378215
😎 Deploy Preview https://deploy-preview-47500--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@a-mccarthy
Copy link
Contributor

@everpeace thanks for opening this!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ed1a02475309ff9dd5bb7215653e495798817692

@everpeace
Copy link
Contributor Author

/assign @sftim

Could you kindly approve this PR? Thank you, in advance!

@sftim
Copy link
Contributor

sftim commented Aug 14, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8a44d27 into kubernetes:main Aug 14, 2024
6 checks passed
@everpeace everpeace deleted the fix-typo-blog-KEP-3619-SupplementalGroupsPolicy branch August 15, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants