Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for kubeadm v1beta4 #19788

Closed
fbyrne opened this issue Oct 10, 2024 · 1 comment · Fixed by #19790
Closed

Add support for kubeadm v1beta4 #19788

fbyrne opened this issue Oct 10, 2024 · 1 comment · Fixed by #19790

Comments

@fbyrne
Copy link
Contributor

fbyrne commented Oct 10, 2024

What Happened?

Version

❯ minikube version
minikube version: v1.34.0
commit: 210b148df93a80eb872ecbeb7e35281b3c582c61

Start Command

minikube start --driver=docker --nodes=6 --ha --dns-domain cluster.dev.local
...
stderr:
W1010 21:32:44.961863    1982 common.go:101] your configuration file uses a deprecated API spec: "kubeadm.k8s.io/v1beta3" (kind: "ClusterConfiguration"). Please use 'kubeadm config migrate --old-config old.yaml --new-config new.yaml', which will write the new, similar spec using a newer API version.
W1010 21:32:44.962186    1982 common.go:101] your configuration file uses a deprecated API spec: "kubeadm.k8s.io/v1beta3" (kind: "InitConfiguration"). Please use 'kubeadm config migrate --old-config old.yaml --new-config new.yaml', which will write the new, similar spec using a newer API version.
	[WARNING Swap]: swap is supported for cgroup v2 only. The kubelet must be properly configured to use swap. Please refer to https://kubernetes.io/docs/concepts/architecture/nodes/#swap-memory, or disable swap on the node
	[WARNING SystemVerification]: failed to parse kernel config: unable to load kernel module: "configs", output: "modprobe: FATAL: Module configs not found in directory /lib/modules/6.8.0-45-generic\n", err: exit status 1
	[WARNING Service-Kubelet]: kubelet service is not enabled, please run 'systemctl enable kubelet.service'
	[WARNING DirAvailable--var-lib-minikube-etcd]: /var/lib/minikube/etcd is not empty

Happy to work on the support if not already developed.

Attach the log file

n/a

Operating System

None

Driver

None

@spowelljr
Copy link
Member

I missed that there was a new kubeadm API, so we have no work on this yet. If you're interested in working on it see the following for the kubeadm templates: https://github.com/kubernetes/minikube/tree/master/pkg/minikube/bootstrapper/bsutil/ktmpl

And where we use the proper template depending on the K8s version in use:

configTmpl := ktmpl.V1Beta1
// v1beta2 isn't required until v1.17.
if version.GTE(semver.MustParse("1.17.0")) {
configTmpl = ktmpl.V1Beta2
}
// v1beta3 isn't required until v1.23.
if version.GTE(semver.MustParse("1.23.0")) {
configTmpl = ktmpl.V1Beta3
}
// TODO: support v1beta4 kubeadm config when released - refs: https://kubernetes.io/docs/reference/config-api/kubeadm-config.v1beta4/ and https://github.com/kubernetes/kubeadm/issues/2890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants