Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please move pkg/credentialprovider out of tree #82396

Closed
jonjohnsonjr opened this issue Sep 6, 2019 · 20 comments
Closed

Please move pkg/credentialprovider out of tree #82396

jonjohnsonjr opened this issue Sep 6, 2019 · 20 comments
Assignees
@andrewsykim
Labels
area/code-organization Issues or PRs related to kubernetes code organization kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider.

Comments

@jonjohnsonjr
Copy link

What would you like to be added:

I would like to be able to import pkg/credentialprovider.

Why is this needed:

google/go-containerregistry#496
@jonjohnsonjr jonjohnsonjr added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 6, 2019
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 6, 2019
@jonjohnsonjr
Copy link
Author

/sig auth
/sig release
/sig cloud-provider

cc @fejta @imjasonh @bobcatfish

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 6, 2019
@liggitt
Copy link
Member

liggitt commented Sep 6, 2019

See also #74379

/area code-organization

@k8s-ci-robot k8s-ci-robot added the area/code-organization Issues or PRs related to kubernetes code organization label Sep 6, 2019
@BenTheElder
Copy link
Member

cc

@andrewsykim
Copy link
Member

cc @mcrute @nckturner @M00nF1sh

@andrewsykim
Copy link
Member

So @mcrute is doing some work on external credential providers kubernetes/enhancements#1284 -- but I wonder if it's worthwhile to stage pkg/credentalprovider in the meantime anyways? Are there enough external consumers of pkg/credentialprovider to justify this?

@jonjohnsonjr
Copy link
Author

I wonder if it's worthwhile to stage pkg/credentalprovider in the meantime anyways?

I think it would be nice from an open source stewardship perspective. There's been a mechanism in go since 1.4 for making packages private that kubernetes doesn't use. Instead, kubernetes just intentionally breaks anyone who took a dependency on the "wrong" packages, which, IMHO, is pretty rude 😄

Are there enough external consumers of pkg/credentialprovider to justify this?

I get harassed about this pretty frequently, so I'd certainly appreciate it 😄 How many people would have to be affected by this to make it worth doing?

@andrewsykim
Copy link
Member

/assign

@jonjohnsonjr jonjohnsonjr mentioned this issue Oct 18, 2019
Closed
@tallclair tallclair removed the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Oct 30, 2019
@jonjohnsonjr jonjohnsonjr mentioned this issue Nov 8, 2019
Closed
@jonjohnsonjr
Copy link
Author

Is there any way I can help with this?

@glyn
Copy link

glyn commented Dec 17, 2019

https://github.com/google/go-containerregistry is consumed by many projects including some that I'm involved with, so I'd like to see progress on this issue and am also happy to help. How's it going @andrewsykim?

@dims
Copy link
Member

dims commented Dec 17, 2019

@glyn @jonjohnsonjr let's help by reviewing kubernetes/enhancements#1406

@glyn glyn mentioned this issue Dec 18, 2019
Merged
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 16, 2020
@justaugustus justaugustus removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Mar 24, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 22, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 22, 2020
@k8s-ci-robot k8s-ci-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jul 22, 2020
@nikhita
Copy link
Member

nikhita commented Jul 23, 2020

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jul 23, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 20, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 20, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewsykim andrewsykim

Labels
area/code-organization Issues or PRs related to kubernetes code organization kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests