Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ComponentConfig for the kube-proxy #527

Closed
luxas opened this issue Nov 8, 2017 · 0 comments · Fixed by kubernetes/kubernetes#55972
Closed

Use ComponentConfig for the kube-proxy #527

luxas opened this issue Nov 8, 2017 · 0 comments · Fixed by kubernetes/kubernetes#55972
Assignees
@danehans
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1.9

Comments

@luxas
Copy link
Member

luxas commented Nov 8, 2017 •
edited
Loading

Important feature for v1.9; dependency for IPv6 support as well

Now that kubernetes/kubernetes#53645 merged, we can start using the kube-proxy ComponentConfig API

Relevant PR for graduating the API group to beta: kubernetes/kubernetes#55234
Relevant PR for kubeadm with discussion on this topic: kubernetes/kubernetes#50929

WIP: rpothier/kubernetes@ea25784#diff-e3ad35b550d4fcbf99d00903a91c787e

The type would look like this in its simplest, earliest form:

type KubeProxy struct {
     Config kubeproxyconfig.KubeProxyConfiguration
}

Then cmd/kubeadm/app/utils.MarshalToYaml will be used for serializing the object to bytes and this should then be written into the kube-proxy ConfigMap in the kube-system namespace, in the config.yaml key.

And the kube-proxy DaemonSet should be different for v1.8 and v1.9; where the v1.9 manifest only has one flag: --config.

@rpothier @danehans @leblancd
@luxas luxas added kind/enhancement priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Nov 8, 2017
@luxas luxas added this to the v1.9 milestone Nov 8, 2017
This was referenced Nov 8, 2017
Closed
Closed
@rpothier rpothier mentioned this issue Nov 17, 2017
Merged
@luxas luxas mentioned this issue Nov 18, 2017
Closed
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Nov 24, 2017
Merge pull request #55972 from rpothier/v6_proxy_bind_addr
0b597b5 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Use kube-proxy ComponentConfig in kubeadm clusters

This change adds configuring the kube-proxy bind address to be an
IPv6 address based on the whether the API server advertise address is IPv6.

It is doing this via the kube-proxy ComponentConfig API now from v1.9

**What this PR does / why we need it**:
This PR sets the bind address for kube-proxy to be a IPv6 address. This is needed for IPv6

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes #50927
Fixes kubernetes/kubeadm#527

**Special notes for your reviewer**:

**Release note**:

```release-note
Adds kubeadm support for using ComponentConfig for the kube-proxy
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danehans danehans

Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v1.9
Development

Successfully merging a pull request may close this issue.

Use kube-proxy ComponentConfig in kubeadm clusters rpothier/kubernetes
2 participants
@danehans @luxas