Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the kubeadm API group self-explainatory by adding comments to all fields #336

Closed
luxas opened this issue Jul 5, 2017 · 3 comments
Closed

Make the kubeadm API group self-explainatory by adding comments to all fields #336

luxas opened this issue Jul 5, 2017 · 3 comments
Assignees
@0xmichalis
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. triaged
Milestone
v1.10

Comments

@luxas
Copy link
Member

luxas commented Jul 5, 2017

And structs, and in the files in general.

Sub-task of #117
@luxas luxas added this to the v1.8 milestone Jul 5, 2017
@luxas luxas added kind/enhancement priority/backlog Higher priority than priority/awaiting-more-evidence. labels Jul 5, 2017
@luxas luxas modified the milestones: v1.9, v1.8 Aug 22, 2017
@luxas
Copy link
Member Author

luxas commented Aug 22, 2017

Moving this to v1.9, where a holistic pass on refreshing the API and making v1alpha2 and/or v1beta1 API groups is planned

@luxas luxas modified the milestones: v1.9, v1.10 Nov 18, 2017
@timothysc timothysc added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 24, 2018
@0xmichalis
Copy link
Contributor

I will take a look

/assign

@0xmichalis
Copy link
Contributor

/remove-help

@k8s-ci-robot k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 24, 2018
@0xmichalis 0xmichalis mentioned this issue Feb 4, 2018
Merged
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Feb 7, 2018
Merge pull request #59325 from kargakis/kubeadm-api-docs
13ad4ca 
Automatic merge from submit-queue (batch tested with PRs 58444, 59283, 59437, 59325, 59449). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Document kubeadm API

Fixes kubernetes/kubeadm#336

@kubernetes/sig-cluster-lifecycle-pr-reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xmichalis 0xmichalis

Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. triaged
Projects
None yet
Milestone
v1.10
Development

No branches or pull requests
4 participants
@timothysc @0xmichalis @luxas @k8s-ci-robot