Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make /etc/kubernetes/ a constant #147

Closed
luxas opened this issue Feb 8, 2017 · 6 comments
Closed

Make /etc/kubernetes/ a constant #147

luxas opened this issue Feb 8, 2017 · 6 comments
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@luxas
Copy link
Member

luxas commented Feb 8, 2017

The /etc/kubernetes/ path should be a constant in kubeadm and not changeable. We have to draw the line between configurability and standardization, and if you do want to use an other path (although there's no reason to), a lot of other things will break.

So myself and @mikedanese made the decision in #100 that this path should not be configurable, it's a standardized path for k8s deployments.

In the same manner, /etc/kubernetes/manifests is the standardized path for Static Pods.

Right now, /etc/kubernetes is configurable via an env param in kubeadm, which leads to extra complexity.
Instead, a constant should be made in cmd/kubeadm/app/constants and consumed everywhere.

@luxas luxas added this to the v1.6 milestone Feb 8, 2017
@luxas
Copy link
Member Author

luxas commented Feb 8, 2017

I think this could be a good first contribution for @wilkers-steve and @larryrensing 👍

@wilkers-steve
Copy link

@luxas Sounds good! We'll start on this today

@luxas luxas removed this from the v1.6 milestone Feb 24, 2017
@luxas luxas self-assigned this May 29, 2017
@luxas luxas added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. labels May 29, 2017
@fabriziopandini
Copy link
Member

This topic is related also to kubeadm #45008 kubernetes/kubernetes#45008 addresses "Fix behaviour of parameters insensible to KUBE_KUBERNETES_DIR env var"

@pipejakob
Copy link
Contributor

pipejakob commented Jun 24, 2017

It looks like the const exists now, but is it still desirable to completely kill the ability to override it? #232 seems to be a valid usecase for wanting to write files elsewhere, if the user really knows what they're doing.

@luxas
Copy link
Member Author

luxas commented Jun 24, 2017

@pipejakob @errordeveloper How common is it to have /etc ro-mounted? Is it possible to ln -s in some way to workaround that while keeping /etc/kubernetes a constant in kubeadm.
I want to minimize complexity inside of the tool and I think having the manifests in different places may mostly lead to confusion... as noted in the design proposal

@luxas
Copy link
Member Author

luxas commented Jul 20, 2017

Now fixed

@luxas luxas closed this as completed Jul 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

4 participants