-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make /etc/kubernetes/ a constant #147
Comments
I think this could be a good first contribution for @wilkers-steve and @larryrensing 👍 |
@luxas Sounds good! We'll start on this today |
This topic is related also to kubeadm #45008 kubernetes/kubernetes#45008 addresses "Fix behaviour of parameters insensible to KUBE_KUBERNETES_DIR env var" |
It looks like the const exists now, but is it still desirable to completely kill the ability to override it? #232 seems to be a valid usecase for wanting to write files elsewhere, if the user really knows what they're doing. |
@pipejakob @errordeveloper How common is it to have |
Now fixed |
The
/etc/kubernetes/
path should be a constant in kubeadm and not changeable. We have to draw the line between configurability and standardization, and if you do want to use an other path (although there's no reason to), a lot of other things will break.So myself and @mikedanese made the decision in #100 that this path should not be configurable, it's a standardized path for k8s deployments.
In the same manner,
/etc/kubernetes/manifests
is the standardized path for Static Pods.Right now,
/etc/kubernetes
is configurable via an env param in kubeadm, which leads to extra complexity.Instead, a constant should be made in
cmd/kubeadm/app/constants
and consumed everywhere.The text was updated successfully, but these errors were encountered: