Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3619: update Test Plan and Graduation Criteria for KEP freeze #3862

Merged
merged 3 commits into from
Feb 9, 2023
Merged

KEP-3619: update Test Plan and Graduation Criteria for KEP freeze #3862

merged 3 commits into from
Feb 9, 2023
+153 −37

Conversation

everpeace
Copy link
Contributor

@everpeace everpeace commented Feb 9, 2023 •
edited
Loading

KEP Freeze requirements:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 9, 2023
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2023
@everpeace
Copy link
Contributor Author

/assign @mrunalp @thockin @SergeyKanzhelev

@everpeace
Copy link
Contributor Author

/cc @mrunalp @thockin @SergeyKanzhelev

@everpeace

This comment was marked as off-topic.

Sign in to view
@everpeace everpeace mentioned this pull request Feb 9, 2023
Open
28 tasks
thockin
thockin reviewed Feb 9, 2023
View reviewed changes
keps/sig-node/3619-supplemental-groups-policy/README.md
@@ -161,6 +247,15 @@ uid=1000(alice) gid=1000(alice) groups=1000(alice),50000(group-in-image),60000

## Motivation

<!--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to keep these comments in the file - it just makes it appear longer :)

thockin
thockin reviewed Feb 9, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are LGTM to me from API and concept, but I am not sig-node approver

keps/sig-node/3619-supplemental-groups-policy/README.md

Are there any tests that were run/should be run to understand performance characteristics better
and validate the declared limits?
-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Answer here should be "No" I think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

should be No

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
-->
-->
No

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK to merge without this answer to hit the KEP deadline

SergeyKanzhelev
SergeyKanzhelev reviewed Feb 9, 2023
View reviewed changes
keps/sig-node/3619-supplemental-groups-policy/README.md

**For non-optional features moving to GA, the graduation criteria must include
[conformance tests].**
- At least one of Container Runtimes which is not based on the classic container, gVisor for example, supports the updated CRI and released
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fvoznika FYI on this development

SergeyKanzhelev
SergeyKanzhelev approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2023
@dchen1107 dchen1107 added this to the v1.27 milestone Feb 9, 2023
@dchen1107
Copy link
Member

/lgtm
/approve

@everpeace please send cleanup PR after the deadline. Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, everpeace, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 811260c into kubernetes:master Feb 9, 2023
@everpeace everpeace mentioned this pull request Feb 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@mrunalp mrunalp

@thockin thockin

@dchen1107 dchen1107

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.
6 participants
@everpeace @dchen1107 @k8s-ci-robot @thockin @SergeyKanzhelev @mrunalp