Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cloud-provider-aws docs #21

Closed
wants to merge 1 commit into from
Closed

Update cloud-provider-aws docs #21

wants to merge 1 commit into from

Conversation

mcrute
Copy link
Contributor

@mcrute mcrute commented Nov 16, 2018

This is the start of the cloud provider docs for the 1.13 release.

/milestone v1.13
/kind feature
/sig aws
/sig cloud-provider

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/provider/aws Issues or PRs related to aws provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 16, 2018
@mcrute
Copy link
Contributor Author

mcrute commented Nov 16, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 16, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 16, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2018
@k8s-ci-robot k8s-ci-robot requested a review from d-nishi December 3, 2018 16:50
@mcrute
Copy link
Contributor Author

mcrute commented Dec 3, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 3, 2018
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2018
Copy link
Contributor

@nckturner nckturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nckturner
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: d-nishi, mcrute, nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [d-nishi,mcrute,nckturner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

@d-nishi d-nishi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcrute -- the documentation is not complete.

How does a user compile the external-ccm and run this as a daemon-set on the master node?

please reference the KEP here: https://github.com/kubernetes/enhancements/blob/master/keps/sig-cloud-provider/0019-cloud-provider-documentation.md
please reference the external-ccm from digitalocean here: https://github.com/digitalocean/digitalocean-cloud-controller-manager

  1. We need the Dockerfile to compile the ccm image.
  2. The image should be placed in AWS's approved docker hub account.
  3. There should be a sample manifest for the ccm - please use the daemonset example listed from the KEP example and the digitalocean cloudprovider example.

@d-nishi
Copy link

d-nishi commented Dec 12, 2018

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2018
@darwin67
Copy link

darwin67 commented Jan 21, 2019

1.13.2 is already out and 1.14.0 is on it's way. why is this still on hold?

I wasted a day trying to figure out why this project doesn't work and found the docs saying it's alpha still hanging around like this.

It'll be great if you can merge this at least to make sure that others don't go through the same rabbit hole.

@d-nishi
Copy link

d-nishi commented Jan 21, 2019

@mcrute can you please do the needful per comments.

This has been pending for a while now.

@leakingtapan
Copy link

/retest

@k8s-ci-robot
Copy link
Contributor

@mcrute: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-cloud-provider-aws-check 316bd08 link /test pull-cloud-provider-aws-check
pull-cloud-provider-aws-test 316bd08 link /test pull-cloud-provider-aws-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mcrute
Copy link
Contributor Author

mcrute commented Feb 19, 2019

/close

@mcrute mcrute closed this Feb 19, 2019
@@ -0,0 +1,40 @@
# Amazon Cloud Controller Manager

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcrute why did you close this?
could you at least put this file in so it doesn't mislead people that this is currently usable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants