-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cloud-provider-aws docs #21
Conversation
/hold |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: d-nishi, mcrute, nckturner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcrute -- the documentation is not complete.
How does a user compile the external-ccm and run this as a daemon-set on the master node?
please reference the KEP here: https://github.com/kubernetes/enhancements/blob/master/keps/sig-cloud-provider/0019-cloud-provider-documentation.md
please reference the external-ccm from digitalocean here: https://github.com/digitalocean/digitalocean-cloud-controller-manager
- We need the Dockerfile to compile the ccm image.
- The image should be placed in AWS's approved docker hub account.
- There should be a sample manifest for the ccm - please use the daemonset example listed from the KEP example and the digitalocean cloudprovider example.
/hold |
I wasted a day trying to figure out why this project doesn't work and found the docs saying it's alpha still hanging around like this. It'll be great if you can merge this at least to make sure that others don't go through the same rabbit hole. |
@mcrute can you please do the needful per comments. This has been pending for a while now. |
/retest |
@mcrute: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/close |
@@ -0,0 +1,40 @@ | |||
# Amazon Cloud Controller Manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcrute why did you close this?
could you at least put this file in so it doesn't mislead people that this is currently usable?
This is the start of the cloud provider docs for the 1.13 release.
/milestone v1.13
/kind feature
/sig aws
/sig cloud-provider