Skip to content

Commit 3bbcc94

Browse files
Merge pull request #125661 from mjudeikis/mjudeikis/poststarthookctx.stopch.cleanup
Clean deprecated context.StopCh Kubernetes-commit: bb350f711174670443e23aa3616606870a471bd7
2 parents 876df11 + 4df8aea commit 3bbcc94

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

pkg/apiserver/apiserver.go

+9-9
Original file line numberDiff line numberDiff line change
@@ -220,7 +220,7 @@ func (c completedConfig) New(delegationTarget genericapiserver.DelegationTarget)
220220
)
221221

222222
s.GenericAPIServer.AddPostStartHookOrDie("start-apiextensions-informers", func(context genericapiserver.PostStartHookContext) error {
223-
s.Informers.Start(context.StopCh)
223+
s.Informers.Start(context.Done())
224224
return nil
225225
})
226226
s.GenericAPIServer.AddPostStartHookOrDie("start-apiextensions-controllers", func(context genericapiserver.PostStartHookContext) error {
@@ -231,20 +231,20 @@ func (c completedConfig) New(delegationTarget genericapiserver.DelegationTarget)
231231
if s.GenericAPIServer.StaticOpenAPISpec != nil {
232232
if s.GenericAPIServer.OpenAPIVersionedService != nil {
233233
openapiController := openapicontroller.NewController(s.Informers.Apiextensions().V1().CustomResourceDefinitions())
234-
go openapiController.Run(s.GenericAPIServer.StaticOpenAPISpec, s.GenericAPIServer.OpenAPIVersionedService, context.StopCh)
234+
go openapiController.Run(s.GenericAPIServer.StaticOpenAPISpec, s.GenericAPIServer.OpenAPIVersionedService, context.Done())
235235
}
236236

237237
if s.GenericAPIServer.OpenAPIV3VersionedService != nil {
238238
openapiv3Controller := openapiv3controller.NewController(s.Informers.Apiextensions().V1().CustomResourceDefinitions())
239-
go openapiv3Controller.Run(s.GenericAPIServer.OpenAPIV3VersionedService, context.StopCh)
239+
go openapiv3Controller.Run(s.GenericAPIServer.OpenAPIV3VersionedService, context.Done())
240240
}
241241
}
242242

243-
go namingController.Run(context.StopCh)
244-
go establishingController.Run(context.StopCh)
245-
go nonStructuralSchemaController.Run(5, context.StopCh)
246-
go apiApprovalController.Run(5, context.StopCh)
247-
go finalizingController.Run(5, context.StopCh)
243+
go namingController.Run(context.Done())
244+
go establishingController.Run(context.Done())
245+
go nonStructuralSchemaController.Run(5, context.Done())
246+
go apiApprovalController.Run(5, context.Done())
247+
go finalizingController.Run(5, context.Done())
248248

249249
discoverySyncedCh := make(chan struct{})
250250
go discoveryController.Run(context.StopCh, discoverySyncedCh)
@@ -265,7 +265,7 @@ func (c completedConfig) New(delegationTarget genericapiserver.DelegationTarget)
265265
return true, nil
266266
}
267267
return false, nil
268-
}, context.StopCh)
268+
}, context.Done())
269269
})
270270

271271
return s, nil

0 commit comments

Comments
 (0)