Update the installation URL of golangci-lint #784
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
| @@ -23,7 +23,7 @@ gopath="$(go env GOPATH)" | |||
| if ! [[ -x "$gopath/bin/golangci-lint" ]]; then | |||
| echo >&2 'Installing golangci-lint' | |||
| curl --silent --fail --location \ | |||
| https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b "$gopath/bin" v1.44.0 | |||
| https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b "$gopath/bin" v1.44.0 | |||
There was a problem hiding this comment.
let's just do go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.46.2 as the project page suggests?
There was a problem hiding this comment.
Note that the project doesn't recommend it:
Install from Source
Note: such go install/go get installation aren't guaranteed to work. We recommend using binary installation.
Anyway, pushed the change via d80edeb (it's a bit slower than the binary installation, comparing https://github.com/kubernetes-sigs/krew/runs/6596083051?check_suite_focus=true and https://github.com/kubernetes-sigs/krew/runs/6592749482?check_suite_focus=true).
Didn't update the version because some newer versions have a lint issue, see #778 (comment).
There was a problem hiding this comment.
we can revert back to https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b "$gopath/bin" v1.44.0 if you want.
There was a problem hiding this comment.
I'm new here and don't have a strong opinion, but using the precompiled binary seems enough on CI. Dropped the commit but if someone prefers go install one, I'm happy to push back it :)
JohnTitor
force-pushed
the
update-install-url-golangci-lint
branch
from
d80edeb to
a9a0f28
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmetb, JohnTitor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Installation via https://install.goreleaser.com has been deprecated and now the server is unavailable, this replaces it with a recommend way stated on https://golangci-lint.run/usage/install/.
This will fix the CI issue e.g. https://github.com/kubernetes-sigs/krew/actions/runs/2384314784