Consider add Go Vet tool in the CI

[Dentrax]

Since we already use golangci-lint static analysis in the run-lint.sh file, adding the yet another static analysis tool (a.k.a go vet) would still makes sense. In order to detect suspicious constructs (too see registered analyzers: go tool vet help), we should use that official tool. (We are still covering some cases, by using .golangci.yaml config file.)

[ahmetb]

I believe go vet is already run as part of that. Do you see any output from go vet?

[Dentrax]

As far as i know, go vet is not part of golangci. But it covers some of cases. I just opened a PR about this, btw. 🙃
Edit: Currently, go vet returns 0.

[chriskim06]

It seems like it is part of golangci-lint https://golangci-lint.run/usage/linters/, but I think would have to be added to this list https://github.com/kubernetes-sigs/krew/blob/master/.golangci.yml#L40

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale