Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding DefaultIndexURI from an env variable #637

Closed
2 tasks
corneliusweig opened this issue Aug 22, 2020 · 5 comments · Fixed by #669
Closed
2 tasks

Allow overriding DefaultIndexURI from an env variable #637

corneliusweig opened this issue Aug 22, 2020 · 5 comments · Fixed by #669
Assignees

Comments

@corneliusweig
Copy link
Contributor

We want to give operators who do not want to install from the default krew index the possibility to provide their own release branch of krew. For that, we should allow overriding the DefaultIndexURI from an env variable, e.g. KREW_DEFAULT_INDEX_URI.
Then operators can start using their own index (containing some krew plugin) from scratch. This will then also set up the default index and point to this custom index location.

  • Implement override via env variable.
  • Update the documentation for custom indices.

/cc @chriskim06

@ahmetb
Copy link
Member

ahmetb commented Aug 23, 2020

I'm supportive. This likely only benefits people who never want to touch krew’s own default.

@chriskim06
Copy link
Member

Is this something we need before 0.4.0?

@ahmetb
Copy link
Member

ahmetb commented Aug 24, 2020

No, I think it can be done later.

@chriskim06
Copy link
Member

Been busy this week, but I'll try to take a crack at this this weekend. I have a feeling integration testing might be interesting but I haven't taken a close look yet.

@chriskim06
Copy link
Member

This completely fell off my radar, I'll try to get to this soon

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants