Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack/run-integration-tests: runs all tests #224

Closed
ahmetb opened this issue Jun 25, 2019 · 2 comments · Fixed by #228
Closed

hack/run-integration-tests: runs all tests #224

ahmetb opened this issue Jun 25, 2019 · 2 comments · Fixed by #228
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@ahmetb
Copy link
Member

ahmetb commented Jun 25, 2019

hack/run-integration-tests.sh hsa go test -v ./..., that's why it's running all tests.

This must use ${SCRIPTDIR}/../test. And ideally we should rename ./test to /.integration_tests.

@ahmetb ahmetb changed the title run-integration-tests: runs all tests hack/run-integration-tests: runs all tests Jun 25, 2019
@ahmetb ahmetb added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/bug Categorizes issue or PR as related to a bug. and removed kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 25, 2019
@corneliusweig
Copy link
Contributor

Go caches test results, so that every re-executed test should be fast. Or are you worried more about duplicated test results in the CI output?

@ahmetb
Copy link
Member Author

ahmetb commented Jun 26, 2019

I mean the script's filename says one thing, it does another thing. :) That's the main problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants