hack/verify-code-patterns.sh: fails locally

[ahmetb]

When I run hack/verify-code-patterns.sh from the root (at d6629aa) it fails with exitcode=1 without any output. This looks bad in hack/run-tests.sh.

Throwing a set -x shows some stuff:

hack/verify-code-patterns.sh
++ find . -name '*_test.go' -not -path './vendor/*' -print0
++ xargs -0 grep -En 'ioutil\.TempDir'
++ [[ 1 == 123 ]]
+ out=

So it looks like for some reason on my shell, exitcode is 1, and not 123.

Although, when I run it on zsh directly, it works.

$ find . -name '*_test.go' -not -path './vendor/*' -print0 | xargs -0 grep -En 'ioutil\.TempDir' || [[ $? == 123 ]]; echo $?
0

I think we need a cleaner solution that doesn't do [[ $? == 123 ]].

[ahmetb]

Oh also this script should use ${SCRIPTDIR}/.. to specify the source directory to find.

[ahmetb]

/kind bug
/kind cleanup

[ahmetb]

this returns 123 in zsh and 1 in bash:

find . -name '*_test.go' -not -path './vendor/*' -print0 | xargs -0 grep -En 'ioutil\.TempDir' || echo $?

weird.

[corneliusweig]

We had some discussion about how to implement this in #191 (comment) . Given that the current solution is not reliable on all platforms, let's use your suggested solution from there.