Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-3619: Support RuntimeFeatures(.features) in "crictl info" command #1772

Merged

Conversation

everpeace
Copy link
Contributor

For:

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds to display RuntimeFeatures object(.features field) in "crictl info" command.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

KEP-3619: "crictl info" now shows "RuntimeFeatures" object(in ".features" field)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 14, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 14, 2025
…crictl info" command

Signed-off-by: Shingo Omura <everpeace@gmail.com>
@everpeace everpeace force-pushed the features-in-crictl-info branch from e9181d3 to 9927d36 Compare February 14, 2025 12:54
@everpeace everpeace marked this pull request as ready for review February 14, 2025 13:05
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mrunalp February 14, 2025 13:05
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2025
@saschagrunert
Copy link
Member

Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everpeace, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit deed6c8 into kubernetes-sigs:master Feb 17, 2025
36 checks passed
@everpeace everpeace deleted the features-in-crictl-info branch February 17, 2025 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants