Serve metrics even if not leader

Author: JoelSpeed

pkg/manager/internal.go

@@ -192,6 +192,13 @@ func (cm *controllerManager) serveMetrics(stop <-chan struct{}) {
 }
 
 func (cm *controllerManager) Start(stop <-chan struct{}) error {
+	// Metrics should be served whether the controller is leader or not.
+	// (If we don't serve metrics for non-leaders, prometheus will still scrape
+	// the pod but will get a connection refused)
+	if cm.metricsListener != nil {
+		go cm.serveMetrics(stop)
+	}
+
 	if cm.resourceLock != nil {
 		err := cm.startLeaderElection(stop)
 		if err != nil {
@@ -227,11 +234,6 @@ func (cm *controllerManager) start(stop <-chan struct{}) {
 		}
 	}()
 
-	// Start the metrics server
-	if cm.metricsListener != nil {
-		go cm.serveMetrics(stop)
-	}
-
 	// Wait for the caches to sync.
 	// TODO(community): Check the return value and write a test
 	cm.cache.WaitForCacheSync(stop)