Skip to content

Commit 85a065f

Browse files
authored
Merge pull request #212 from shawn-hurley/issue/202-1
Set GVK when getting the object from the cache.
2 parents 0e09a0d + 7fa463a commit 85a065f

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

pkg/cache/cache_test.go

+7
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,13 @@ var _ = Describe("Informer Cache", func() {
8989
knownPod1 = createPod("test-pod-1", testNamespaceOne, kcorev1.RestartPolicyNever)
9090
knownPod2 = createPod("test-pod-2", testNamespaceTwo, kcorev1.RestartPolicyAlways)
9191
knownPod3 = createPod("test-pod-3", testNamespaceTwo, kcorev1.RestartPolicyOnFailure)
92+
podGVK := schema.GroupVersionKind{
93+
Kind: "Pod",
94+
Version: "v1",
95+
}
96+
knownPod1.GetObjectKind().SetGroupVersionKind(podGVK)
97+
knownPod2.GetObjectKind().SetGroupVersionKind(podGVK)
98+
knownPod3.GetObjectKind().SetGroupVersionKind(podGVK)
9299

93100
By("creating the informer cache")
94101
var err error

pkg/cache/internal/cache_reader.go

+1
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ func (c *CacheReader) Get(_ context.Context, key client.ObjectKey, out runtime.O
8181
return fmt.Errorf("cache had type %s, but %s was asked for", objVal.Type(), outVal.Type())
8282
}
8383
reflect.Indirect(outVal).Set(reflect.Indirect(objVal))
84+
out.GetObjectKind().SetGroupVersionKind(c.groupVersionKind)
8485

8586
return nil
8687
}

0 commit comments

Comments
 (0)