fix: memory leak in IPAM caused by leftover map keys (#2566)

oilbeater · oilbeater · commit fb70f9393513 · 2023-03-29T01:52:18.000Z
When all nics are popped from the list the map key still exist which will lead memory leak each time a pod is deleted. (cherry picked from commit 3f7997b)
diff --git a/pkg/ipam/subnet.go b/pkg/ipam/subnet.go
@@ -159,6 +159,9 @@ func (subnet *Subnet) pushPodNic(podName, nicName string) {
 
 func (subnet *Subnet) popPodNic(podName, nicName string) {
 	subnet.PodToNicList[podName] = util.RemoveString(subnet.PodToNicList[podName], nicName)
+	if subnet.PodToNicList[podName] == nil {
+		delete(subnet.PodToNicList, podName)
+	}
 }
 
 func (subnet *Subnet) GetRandomAddress(podName, nicName string, mac string, skippedAddrs []string, checkConflict bool) (IP, IP, string, error) {

Original file line number	Diff line number	Diff line change
`@@ -159,6 +159,9 @@ func (subnet *Subnet) pushPodNic(podName, nicName string) {`
`159`	`159`
`160`	`160`	`func (subnet *Subnet) popPodNic(podName, nicName string) {`
`161`	`161`	`subnet.PodToNicList[podName] = util.RemoveString(subnet.PodToNicList[podName], nicName)`
	`162`	`+ if subnet.PodToNicList[podName] == nil {`
	`163`	`+ delete(subnet.PodToNicList, podName)`
	`164`	`+ }`
`162`	`165`	`}`
`163`	`166`
`164`	`167`	`func (subnet *Subnet) GetRandomAddress(podName, nicName string, mac string, skippedAddrs []string, checkConflict bool) (IP, IP, string, error) {`