Skip to content

Commit bed8229

Browse files
committed
fix gc report error #2886
1 parent 42a5656 commit bed8229

File tree

2 files changed

+15
-12
lines changed

2 files changed

+15
-12
lines changed

pkg/controller/gc.go

+11-9
Original file line numberDiff line numberDiff line change
@@ -685,16 +685,18 @@ func (c *Controller) gcChassis() error {
685685
}
686686

687687
func (c *Controller) isOVNProvided(providerName string, pod *corev1.Pod) (bool, error) {
688-
ls := pod.Annotations[fmt.Sprintf(util.LogicalSwitchAnnotationTemplate, providerName)]
689-
subnet, err := c.config.KubeOvnClient.KubeovnV1().Subnets().Get(context.Background(), ls, metav1.GetOptions{})
690-
if err != nil {
691-
klog.Errorf("parse annotation logical switch %s error %v", ls, err)
692-
return false, err
693-
}
694-
if !strings.HasSuffix(subnet.Spec.Provider, util.OvnProvider) {
695-
return false, nil
688+
if ls, ok := pod.Annotations[fmt.Sprintf(util.LogicalSwitchAnnotationTemplate, providerName)]; ok {
689+
subnet, err := c.subnetsLister.Get(ls)
690+
if err != nil {
691+
klog.Errorf("parse annotation logical switch %s error %v", ls, err)
692+
return false, err
693+
}
694+
if !strings.HasSuffix(subnet.Spec.Provider, util.OvnProvider) {
695+
return false, nil
696+
}
697+
return true, nil
696698
}
697-
return true, nil
699+
return false, nil
698700
}
699701

700702
func (c *Controller) getVmLsps() []string {

pkg/controller/vpc_nat_gw_nat.go

+4-3
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import (
44
"context"
55
"encoding/json"
66
"fmt"
7+
"time"
78

89
k8serrors "k8s.io/apimachinery/pkg/api/errors"
910
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -578,7 +579,7 @@ func (c *Controller) handleUpdateIptablesFip(key string) error {
578579
return err
579580
}
580581
// reset eip
581-
c.resetIptablesEipQueue.Add(cachedFip.Spec.EIP)
582+
c.resetIptablesEipQueue.AddAfter(cachedFip.Spec.EIP, 3*time.Second)
582583
return nil
583584
}
584585
klog.V(3).Infof("handle update fip %s", key)
@@ -759,7 +760,7 @@ func (c *Controller) handleUpdateIptablesDnatRule(key string) error {
759760
return err
760761
}
761762
// reset eip
762-
c.resetIptablesEipQueue.Add(cachedDnat.Spec.EIP)
763+
c.resetIptablesEipQueue.AddAfter(cachedDnat.Spec.EIP, 3*time.Second)
763764
return nil
764765
}
765766
klog.V(3).Infof("handle update dnat %s", key)
@@ -947,7 +948,7 @@ func (c *Controller) handleUpdateIptablesSnatRule(key string) error {
947948
return err
948949
}
949950
// reset eip
950-
c.resetIptablesEipQueue.Add(cachedSnat.Spec.EIP)
951+
c.resetIptablesEipQueue.AddAfter(cachedSnat.Spec.EIP, 3*time.Second)
951952
return nil
952953
}
953954
klog.V(3).Infof("handle update snat %s", key)

0 commit comments

Comments
 (0)