Skip to content

Commit a4cae60

Browse files
committed
netpol: fix packet drop casued by incorrect address set deletion (#2677)
1 parent 96580be commit a4cae60

File tree

1 file changed

+0
-24
lines changed

1 file changed

+0
-24
lines changed

pkg/controller/network_policy.go

-24
Original file line numberDiff line numberDiff line change
@@ -242,18 +242,6 @@ func (c *Controller) handleUpdateNp(key string) error {
242242
}
243243
}
244244

245-
ingressAsNames, err := c.ovnLegacyClient.ListNpAddressSet(np.Namespace, npName, "ingress")
246-
if err != nil {
247-
klog.Errorf("failed to list ingress address_set, %v", err)
248-
return err
249-
}
250-
for _, ingressAsName := range ingressAsNames {
251-
if err = c.ovnLegacyClient.DeleteAddressSet(ingressAsName); err != nil {
252-
klog.Errorf("failed to delete np %s address set, %v", key, err)
253-
return err
254-
}
255-
}
256-
257245
var ingressAclCmd []string
258246
exist, err := c.ovnLegacyClient.PortGroupExists(pgName)
259247
if err != nil {
@@ -389,18 +377,6 @@ func (c *Controller) handleUpdateNp(key string) error {
389377
}
390378
}
391379

392-
egressAsNames, err := c.ovnLegacyClient.ListNpAddressSet(np.Namespace, npName, "egress")
393-
if err != nil {
394-
klog.Errorf("failed to list egress address_set, %v", err)
395-
return err
396-
}
397-
for _, egressAsName := range egressAsNames {
398-
if err = c.ovnLegacyClient.DeleteAddressSet(egressAsName); err != nil {
399-
klog.Errorf("failed to delete np %s address set, %v", key, err)
400-
return err
401-
}
402-
}
403-
404380
var egressAclCmd []string
405381
exist, err = c.ovnLegacyClient.PortGroupExists(pgName)
406382
if err != nil {

0 commit comments

Comments
 (0)