Skip to content

Commit 96e8be6

Browse files
committed
netpol: fix packet drop casued by incorrect address set deletion (#2677)
1 parent 6b95cec commit 96e8be6

File tree

1 file changed

+0
-24
lines changed

1 file changed

+0
-24
lines changed

pkg/controller/network_policy.go

-24
Original file line numberDiff line numberDiff line change
@@ -235,18 +235,6 @@ func (c *Controller) handleUpdateNp(key string) error {
235235
}
236236
}
237237

238-
ingressAsNames, err := c.ovnLegacyClient.ListNpAddressSet(np.Namespace, npName, "ingress")
239-
if err != nil {
240-
klog.Errorf("failed to list ingress address_set, %v", err)
241-
return err
242-
}
243-
for _, ingressAsName := range ingressAsNames {
244-
if err = c.ovnLegacyClient.DeleteAddressSet(ingressAsName); err != nil {
245-
klog.Errorf("failed to delete np %s address set, %v", key, err)
246-
return err
247-
}
248-
}
249-
250238
var ingressAclCmd []string
251239
exist, err := c.ovnLegacyClient.PortGroupExists(pgName)
252240
if err != nil {
@@ -378,18 +366,6 @@ func (c *Controller) handleUpdateNp(key string) error {
378366
}
379367
}
380368

381-
egressAsNames, err := c.ovnLegacyClient.ListNpAddressSet(np.Namespace, npName, "egress")
382-
if err != nil {
383-
klog.Errorf("failed to list egress address_set, %v", err)
384-
return err
385-
}
386-
for _, egressAsName := range egressAsNames {
387-
if err = c.ovnLegacyClient.DeleteAddressSet(egressAsName); err != nil {
388-
klog.Errorf("failed to delete np %s address set, %v", key, err)
389-
return err
390-
}
391-
}
392-
393369
var egressAclCmd []string
394370
exist, err = c.ovnLegacyClient.PortGroupExists(pgName)
395371
if err != nil {

0 commit comments

Comments
 (0)