Skip to content

Commit 9304ae5

Browse files
authored
kube-ovn-controller: fix workqueue metrics (#3011)
1 parent d415388 commit 9304ae5

File tree

5 files changed

+12
-9
lines changed

5 files changed

+12
-9
lines changed

cmd/controller/controller.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@ import (
1313
v1 "k8s.io/api/authorization/v1"
1414
apiv1 "k8s.io/api/core/v1"
1515
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
16-
"k8s.io/apiserver/pkg/server"
1716
"k8s.io/client-go/kubernetes/scheme"
1817
"k8s.io/client-go/tools/leaderelection"
1918
"k8s.io/client-go/tools/leaderelection/resourcelock"
2019
"k8s.io/client-go/tools/record"
2120
"k8s.io/klog/v2"
21+
"sigs.k8s.io/controller-runtime/pkg/manager/signals"
2222

2323
kubeovnv1 "github.com/kubeovn/kube-ovn/pkg/apis/kubeovn/v1"
2424
"github.com/kubeovn/kube-ovn/pkg/controller"
@@ -35,7 +35,7 @@ func CmdMain() {
3535
ctx, cancel := context.WithCancel(context.Background())
3636
defer cancel()
3737
go func() {
38-
stopCh := server.SetupSignalHandler()
38+
stopCh := signals.SetupSignalHandler().Done()
3939
<-stopCh
4040
cancel()
4141
}()

go.mod

+1-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ require (
4242
gopkg.in/k8snetworkplumbingwg/multus-cni.v4 v4.0.2
4343
k8s.io/api v0.27.3
4444
k8s.io/apimachinery v0.27.3
45-
k8s.io/apiserver v0.27.3
4645
k8s.io/client-go v12.0.0+incompatible
4746
k8s.io/klog/v2 v2.100.1
4847
k8s.io/kubectl v0.27.3
@@ -248,6 +247,7 @@ require (
248247
gopkg.in/yaml.v2 v2.4.0 // indirect
249248
gopkg.in/yaml.v3 v3.0.1 // indirect
250249
k8s.io/apiextensions-apiserver v0.27.3 // indirect
250+
k8s.io/apiserver v0.27.3 // indirect
251251
k8s.io/cli-runtime v0.27.3 // indirect
252252
k8s.io/cloud-provider v0.27.3 // indirect
253253
k8s.io/cluster-bootstrap v0.27.3 // indirect

pkg/controller/ovn_dnat.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ import (
66
"fmt"
77
"net"
88

9-
kubeovnv1 "github.com/kubeovn/kube-ovn/pkg/apis/kubeovn/v1"
10-
"github.com/kubeovn/kube-ovn/pkg/util"
119
"github.com/ovn-org/libovsdb/ovsdb"
1210
k8serrors "k8s.io/apimachinery/pkg/api/errors"
1311
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -16,6 +14,9 @@ import (
1614
"k8s.io/client-go/tools/cache"
1715
"k8s.io/klog/v2"
1816
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
17+
18+
kubeovnv1 "github.com/kubeovn/kube-ovn/pkg/apis/kubeovn/v1"
19+
"github.com/kubeovn/kube-ovn/pkg/util"
1920
)
2021

2122
func (c *Controller) enqueueAddOvnDnatRule(obj interface{}) {

pkg/controller/ovn_fip.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,16 @@ import (
55
"encoding/json"
66
"fmt"
77

8-
kubeovnv1 "github.com/kubeovn/kube-ovn/pkg/apis/kubeovn/v1"
9-
"github.com/kubeovn/kube-ovn/pkg/util"
108
k8serrors "k8s.io/apimachinery/pkg/api/errors"
119
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
1210
"k8s.io/apimachinery/pkg/types"
1311
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
1412
"k8s.io/client-go/tools/cache"
1513
"k8s.io/klog/v2"
1614
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
15+
16+
kubeovnv1 "github.com/kubeovn/kube-ovn/pkg/apis/kubeovn/v1"
17+
"github.com/kubeovn/kube-ovn/pkg/util"
1718
)
1819

1920
func (c *Controller) enqueueAddOvnFip(obj interface{}) {

pkg/controller/ovn_snat.go

+3-2
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,16 @@ import (
55
"encoding/json"
66
"fmt"
77

8-
kubeovnv1 "github.com/kubeovn/kube-ovn/pkg/apis/kubeovn/v1"
9-
"github.com/kubeovn/kube-ovn/pkg/util"
108
k8serrors "k8s.io/apimachinery/pkg/api/errors"
119
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
1210
"k8s.io/apimachinery/pkg/types"
1311
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
1412
"k8s.io/client-go/tools/cache"
1513
"k8s.io/klog/v2"
1614
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
15+
16+
kubeovnv1 "github.com/kubeovn/kube-ovn/pkg/apis/kubeovn/v1"
17+
"github.com/kubeovn/kube-ovn/pkg/util"
1718
)
1819

1920
func (c *Controller) enqueueAddOvnSnatRule(obj interface{}) {

0 commit comments

Comments
 (0)