add golang lint (#3154)

* add golang lint

Author: changluyi

.github/workflows/build-x86-image.yaml

@@ -1942,6 +1942,19 @@ jobs:
         working-directory: ${{ env.E2E_DIR }}
         run: make iptables-vpc-nat-gw-conformance-e2e
 
+      - name: kubectl ko log
+        if: failure()
+        run: |
+          make kubectl-ko-log
+          mv kubectl-ko-log.tar.gz iptables-vpc-nat-gw-conformance-e2e-ko-log.tar.gz
+
+      - name: upload kubectl ko log
+        uses: actions/upload-artifact@v3
+        if: failure()
+        with:
+          name: iptables-vpc-nat-gw-conformance-e2e-ko-log
+          path: iptables-vpc-nat-gw-conformance-e2e-ko-log.tar.gz
+
   ovn-vpc-nat-gw-conformance-e2e:
     name: OVN VPC NAT Gateway E2E
     needs:

.github/workflows/lint.yaml

@@ -38,7 +38,6 @@ jobs:
           # working-directory: somedir
 
           # Optional: golangci-lint command line arguments.
-          args: --timeout 20m
-
+          args: --timeout 20m --verbose
           # Optional: show only new issues if it's a pull request. The default value is `false`.
           # only-new-issues: true

.golangci.yml

@@ -0,0 +1,44 @@
+run:
+  timeout: 15m
+
+output:
+  sort-results: true
+
+linters:
+  enable:
+    - gocritic
+    - gofumpt
+    - goimports
+    - misspell
+    - predeclared
+    - revive
+    - unconvert
+    - unused
+    - errcheck
+
+issues:
+  max-same-issues: 0
+  exclude-rules:
+    - linters:
+        - gocritic
+      text: "appendAssign"
+    - linters:
+        - revive
+      text: "don't use an underscore in package name" # package name not change
+    - path: test/unittest/
+      linters:
+        - revive
+      text: "should not use dot imports" # ginkgo coding style
+    - linters:
+        - revive
+      text: "VpcDns should be VpcDNS"  # api param not change
+    - linters:
+        - revive
+      text: "VpcDnsList should be VpcDNSList" # api param not change
+
+linters-settings:
+  goimports:
+    local-prefixes: github.com/kubeovn/kube-ovn
+  gofumpt:
+    extra-rules: true
+

Makefile

@@ -827,6 +827,10 @@ lint:
 	@GOOS=linux go vet ./...
 	@GOOS=linux gosec -exclude=G204,G306,G404,G601,G301 -exclude-dir=test -exclude-dir=pkg/client ./...
 
+.PHONY: gofumpt
+gofumpt: gofumpt
+	gofumpt -w -extra .
+
 .PHONY: lint-windows
 lint-windows:
 	@GOOS=windows go vet ./cmd/windows/...

cmd/cni/cni.go

@@ -82,14 +82,14 @@ func generateCNIResult(cniResponse *request.CniResponse, netns string) current.R
 	}
 	switch cniResponse.Protocol {
 	case kubeovnv1.ProtocolIPv4:
-		ip, route := assignV4Address(cniResponse.IpAddress, cniResponse.Gateway, mask)
+		ip, route := assignV4Address(cniResponse.IPAddress, cniResponse.Gateway, mask)
 		result.IPs = []*current.IPConfig{ip}
 		if route != nil {
 			result.Routes = []*types.Route{route}
 		}
 		result.Interfaces = []*current.Interface{&podIface}
 	case kubeovnv1.ProtocolIPv6:
-		ip, route := assignV6Address(cniResponse.IpAddress, cniResponse.Gateway, mask)
+		ip, route := assignV6Address(cniResponse.IPAddress, cniResponse.Gateway, mask)
 		result.IPs = []*current.IPConfig{ip}
 		if route != nil {
 			result.Routes = []*types.Route{route}
@@ -102,7 +102,7 @@ func generateCNIResult(cniResponse *request.CniResponse, netns string) current.R
 			_, netMask, _ = net.ParseCIDR(cidrBlock)
 			gwStr = ""
 			if util.CheckProtocol(cidrBlock) == kubeovnv1.ProtocolIPv4 {
-				ipStr := strings.Split(cniResponse.IpAddress, ",")[0]
+				ipStr := strings.Split(cniResponse.IPAddress, ",")[0]
 				if cniResponse.Gateway != "" {
 					gwStr = strings.Split(cniResponse.Gateway, ",")[0]
 				}
@@ -113,7 +113,7 @@ func generateCNIResult(cniResponse *request.CniResponse, netns string) current.R
 					result.Routes = append(result.Routes, route)
 				}
 			} else if util.CheckProtocol(cidrBlock) == kubeovnv1.ProtocolIPv6 {
-				ipStr := strings.Split(cniResponse.IpAddress, ",")[1]
+				ipStr := strings.Split(cniResponse.IPAddress, ",")[1]
 				if cniResponse.Gateway != "" {
 					gwStr = strings.Split(cniResponse.Gateway, ",")[1]
 				}

cmd/daemon/cniserver.go

@@ -132,10 +132,10 @@ func mvCNIConf(configDir, configFile, confName string) error {
 	}
 
 	cniConfPath := filepath.Join(configDir, confName)
-	return os.WriteFile(cniConfPath, data, 0644)
+	return os.WriteFile(cniConfPath, data, 0o644)
 }
 
-func Retry(attempts int, sleep int, f func(configuration *daemon.Configuration) error, ctrl *daemon.Configuration) (err error) {
+func Retry(attempts, sleep int, f func(configuration *daemon.Configuration) error, ctrl *daemon.Configuration) (err error) {
 	for i := 0; ; i++ {
 		err = f(ctrl)
 		if err == nil {
@@ -174,13 +174,11 @@ func initChassisAnno(cfg *daemon.Configuration) error {
 	if annoChassesName, ok := node.Annotations[util.ChassisAnnotation]; ok {
 		if annoChassesName == chassesName {
 			return nil
-		} else {
-			klog.Infof("chassis id changed, old: %s, new: %s", annoChassesName, chassesName)
 		}
+		klog.Infof("chassis id changed, old: %s, new: %s", annoChassesName, chassesName)
 	}
 	node.Annotations[util.ChassisAnnotation] = chassesName
-	patchPayloadTemplate :=
-		`[{
+	patchPayloadTemplate := `[{
         "op": "%s",
         "path": "/metadata/annotations",
         "value": %s