Skip to content

Commit 63afc1f

Browse files
committed
ci: fix ovn-ic installation (#2456)
1 parent f790d5a commit 63afc1f

File tree

1 file changed

+12
-14
lines changed

1 file changed

+12
-14
lines changed

Makefile

+12-14
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ base-tar-arm64:
135135
docker save $(REGISTRY)/kube-ovn-base:$(RELEASE_TAG)-arm64 -o image-arm64.tar
136136

137137
define docker_ensure_image_exists
138-
@if ! docker images --format "{{.Repository}}:{{.Tag}}" | grep "^$(1)$$" >/dev/null; then \
138+
if ! docker images --format "{{.Repository}}:{{.Tag}}" | grep "^$(1)$$" >/dev/null; then \
139139
docker pull "$(1)"; \
140140
fi
141141
endef
@@ -208,6 +208,9 @@ define kind_create_cluster
208208
endef
209209

210210
define kind_load_image
211+
@if [ "x$(3)" = "x1" ]; then \
212+
$(call docker_ensure_image_exists,$(2)); \
213+
fi
211214
kind load docker-image --name $(1) $(2)
212215
endef
213216

@@ -236,8 +239,8 @@ kind-init-ipv4: kind-clean
236239
@$(MAKE) kind-create
237240

238241
.PHONY: kind-init-ovn-ic
239-
kind-init-ovn-ic: kind-clean-ovn-ic kind-init-ha
240-
@ha=true $(MAKE) kind-generate-config
242+
kind-init-ovn-ic: kind-clean-ovn-ic kind-init
243+
@$(MAKE) kind-generate-config
241244
$(call kind_create_cluster,yamls/kind.yaml,kube-ovn1)
242245

243246
.PHONY: kind-init-iptables
@@ -332,7 +335,7 @@ kind-install-ipv4: kind-install-overlay-ipv4
332335
kind-install-overlay-ipv4: kind-install
333336

334337
.PHONY: kind-install-ovn-ic
335-
kind-install-ovn-ic: kind-load-image kind-install
338+
kind-install-ovn-ic: kind-install
336339
$(call kind_load_image,kube-ovn1,$(REGISTRY)/kube-ovn:$(VERSION))
337340
kubectl config use-context kind-kube-ovn1
338341
sed -e 's/10.16.0/10.18.0/g' \
@@ -345,17 +348,14 @@ kind-install-ovn-ic: kind-load-image kind-install
345348
docker run -d --name ovn-ic-db --network kind $(REGISTRY)/kube-ovn:$(VERSION) bash start-ic-db.sh
346349
@set -e; \
347350
ic_db_host=$$(docker inspect ovn-ic-db -f "{{.NetworkSettings.Networks.kind.IPAddress}}"); \
348-
zone=az0 ic_db_host=$$ic_db_host gateway_node_name=kube-ovn-control-plane j2 yamls/ovn-ic.yaml.j2 -o ovn-ic-0.yaml; \
349-
zone=az1 ic_db_host=$$ic_db_host gateway_node_name=kube-ovn1-control-plane j2 yamls/ovn-ic.yaml.j2 -o ovn-ic-1.yaml; \
350-
zone=az1111 ic_db_host=$$ic_db_host gateway_node_name=kube-ovn1-control-plane j2 yamls/ovn-ic.yaml.j2 -o /tmp/ovn-ic-1-alter.yaml
351+
zone=az0 ic_db_host=$$ic_db_host gateway_node_name=kube-ovn-worker j2 yamls/ovn-ic.yaml.j2 -o ovn-ic-0.yaml; \
352+
zone=az1 ic_db_host=$$ic_db_host gateway_node_name=kube-ovn1-worker j2 yamls/ovn-ic.yaml.j2 -o ovn-ic-1.yaml
351353
kubectl config use-context kind-kube-ovn
352354
kubectl apply -f ovn-ic-0.yaml
353-
sleep 6
354-
kubectl -n kube-system get pods | grep ovs-ovn | awk '{print $$1}' | xargs kubectl -n kube-system delete pod
355355
kubectl config use-context kind-kube-ovn1
356356
kubectl apply -f ovn-ic-1.yaml
357357
sleep 6
358-
kubectl -n kube-system get pods | grep ovs-ovn | awk '{print $$1}' | xargs kubectl -n kube-system delete pod
358+
docker exec ovn-ic-db ovn-ic-sbctl show
359359

360360
.PHONY: kind-install-underlay
361361
kind-install-underlay: kind-install-underlay-ipv4
@@ -470,8 +470,7 @@ kind-install-underlay-logical-gateway-dual: kind-disable-hairpin kind-load-image
470470

471471
.PHONY: kind-install-multus
472472
kind-install-multus:
473-
$(call docker_ensure_image_exists,$(MULTUS_IMAGE))
474-
$(call kind_load_image,kube-ovn,$(MULTUS_IMAGE))
473+
$(call kind_load_image,kube-ovn,$(MULTUS_IMAGE),1)
475474
kubectl apply -f "$(MULTUS_YAML)"
476475
kubectl -n kube-system rollout status ds kube-multus-ds
477476

@@ -486,8 +485,7 @@ kind-install-lb-svc: kind-load-image kind-untaint-control-plane
486485
.PHONY: kind-install-cilium-chaining
487486
kind-install-cilium-chaining: kind-load-image kind-untaint-control-plane
488487
$(eval KUBERNETES_SERVICE_HOST = $(shell kubectl get nodes kube-ovn-control-plane -o jsonpath='{.status.addresses[0].address}'))
489-
$(call docker_ensure_image_exists,$(CILIUM_IMAGE_REPO):v$(CILIUM_VERSION))
490-
$(call kind_load_image,kube-ovn,$(CILIUM_IMAGE_REPO):v$(CILIUM_VERSION))
488+
$(call kind_load_image,kube-ovn,$(CILIUM_IMAGE_REPO):v$(CILIUM_VERSION),1)
491489
kubectl apply -f yamls/cilium-chaining.yaml
492490
helm repo add cilium https://helm.cilium.io/
493491
helm install cilium cilium/cilium \

0 commit comments

Comments
 (0)