controller: check condition NodeNetworkUnavailable when determining whether node is ready (#4917)

zhangzujian · zhangzujian · commit 1b9a4b906f23 · 2025-01-11T10:02:54.000Z
Signed-off-by: zhangzujian &lt;zhangzujian.7@gmail.com&gt;
diff --git a/pkg/controller/node.go b/pkg/controller/node.go
@@ -47,12 +47,16 @@ func (c *Controller) enqueueAddNode(obj interface{}) {
 }
 
 func nodeReady(node *v1.Node) bool {
-	for _, con := range node.Status.Conditions {
-		if con.Type == v1.NodeReady && con.Status == v1.ConditionTrue {
-			return true
+	var ready, networkUnavailable bool
+	for _, c := range node.Status.Conditions {
+		switch c.Type {
+		case v1.NodeReady:
+			ready = c.Status == v1.ConditionTrue
+		case v1.NodeNetworkUnavailable:
+			networkUnavailable = c.Status == v1.ConditionTrue
 		}
 	}
-	return false
+	return ready && !networkUnavailable
 }
 
 func (c *Controller) enqueueUpdateNode(oldObj, newObj interface{}) {

Original file line number	Diff line number	Diff line change
`@@ -47,12 +47,16 @@ func (c *Controller) enqueueAddNode(obj interface{}) {`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`func nodeReady(node *v1.Node) bool {`
`50`		`- for _, con := range node.Status.Conditions {`
`51`		`- if con.Type == v1.NodeReady && con.Status == v1.ConditionTrue {`
`52`		`- return true`
	`50`	`+ var ready, networkUnavailable bool`
	`51`	`+ for _, c := range node.Status.Conditions {`
	`52`	`+ switch c.Type {`
	`53`	`+ case v1.NodeReady:`
	`54`	`+ ready = c.Status == v1.ConditionTrue`
	`55`	`+ case v1.NodeNetworkUnavailable:`
	`56`	`+ networkUnavailable = c.Status == v1.ConditionTrue`
`53`	`57`	`}`
`54`	`58`	`}`
`55`		`- return false`
	`59`	`+ return ready && !networkUnavailable`
`56`	`60`	`}`
`57`	`61`
`58`	`62`	`func (c *Controller) enqueueUpdateNode(oldObj, newObj interface{}) {`