Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

kfdef application name missing doesnt fail kfctl build #437

Closed
moficodes opened this issue Nov 10, 2020 · 3 comments · Fixed by #438
Closed

kfdef application name missing doesnt fail kfctl build #437

moficodes opened this issue Nov 10, 2020 · 3 comments · Fixed by #438
Assignees

Comments

@moficodes
Copy link
Contributor

kind: KfDef
metadata:
  namespace: kubeflow
spec:
  applications:
# other applications omitted
  - kustomizeConfig:
      repoRef:
        name: manifests
        path: stacks/ibm/application/spartakus
#    name: spartakus
  repos:
  - name: manifests
    uri: https://github.com/moficodes/manifests/archive/master.tar.gz
  version: master

The above kfdef builds fine. but apply would fail and the error message is completely unrelated.

ERRO[0001] Error evaluating kustomization manifest for : accumulating resources: accumulating resources from '../../../../common/spartakus/overlays/application': open /common/spartakus/overlays/application: no such file or directory  filename="kustomize/kustomize.go:155"
Error: failed to apply:  (kubeflow.error): Code 500 with message: kfApp Apply failed for kustomize:  (kubeflow.error): Code 500 with message: error evaluating kustomization manifest for : accumulating resources: accumulating resources from '../../../../common/spartakus/overlays/application': open /common/spartakus/overlays/application: no such file or directory

We should add a check for application name or infer name from path.

@moficodes
Copy link
Contributor Author

cc @Tomcli

@moficodes
Copy link
Contributor Author

/assign

@Tomcli
Copy link
Member

Tomcli commented Nov 10, 2020

Raise an error is better in this case because the user can also miss other fields.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants