Automated footer year #668
Conversation
Signed-off-by: Vicky Besra <vickybesra2000@gmail.com>
Signed-off-by: Vicky Besra <vickybesra2000@gmail.com>
kubeedge-bot
added
the
size/S
docusaurus.config.js
Outdated
| const currentYear = new Date().getFullYear(); | ||
| const localizedCopyrights = { | ||
| en: `${currentYear} © KubeEdge Project Authors. All rights reserved.`, | ||
| zh: `${currentYear} © KubeEdge 项目作者。版权所有。`, |
There was a problem hiding this comment.
Do we need to have this Chinese version of footer in here? i think this is meant to be English version only, so i think it works okay with current implementation.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "copyright": { | |||
| "message": "2024 © KubeEdge Project Authors. All rights reserved.", | |||
| "message": "2025 © KubeEdge Project Authors. All rights reserved.", | |||
|
I am not sure how to automate the copyright in (https://github.com/kubeedge/website/blob/master/i18n/zh/docusaurus-theme-classic/footer.json) |
There was a problem hiding this comment.
Overall looks good. Could you squash some commits?https://kubeedge.io/docs/developer/Supplemental_developer_guide#ensuring-to-squash-similiar-commits
|
Sure |
Signed-off-by: Vicky Besra <vickybesra2000@gmail.com> removed extra spaces and comments Signed-off-by: Vicky Besra <vickybesra2000@gmail.com> Automated footer year for chinese and english
vickybesra
force-pushed
the
automate-footer-year
branch
from
552a197 to
8db8d98
Compare
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Shelley-BaoYue The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
approved
Which issue(s) this PR fixes:
Fixes #597