-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a newline to pem blobs if one is not present #505
Conversation
…resent, this will make openssl a bit more forgiving for non-conforming pems
@clux Looks like rustfmt job failed for some reason. https://github.com/clux/kube-rs/runs/2423729395 |
Thanks for this. Yeah, it looks sensible to me, though hope it doesn't come back to bite us due to windows line endings :D I'd just drop the other fmt changes - if* it's not a problem. They are probably mismatching rustfmt versions (we use nightly fmt). |
@clux - Those were formatted with Either way, I'll look at the rustfmt CI job discrepancies and make it work. |
Removing other files from the PR like the following should be enough? git reset HEAD~
git add kube/src/config/utils.rs
git restore . # restore other files
git commit
git push --force-with-lease Other files should be formatted by GitHub Actions after merging. The rustfmt job failed last time for unknown reason. |
I thought I had seen GitHub Action formatting code and pushing commit when necessary, but I guess I misremembered (maybe it was from other repo). |
If it's possible to do that, then that's great. Usually I have been doing a quick Turns out the stray formatting issues in there was my fault - had merged some prs and forgotten to do it. |
Released in 0.53.0. Thanks again. |
/fixes #504
I'm not sure where is the best place to put this routine.
The function I chose isn't technically limited to loading PEM files, but it's currently not used for anything else.
It's the only place I found where we'd only have to invoke the routine once.
The only actual change is in
src/config/utils.rs
the rest are formatting changes.