Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hyper-rustls minimum version #1575

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

divergentdave
Copy link
Contributor

Motivation

I updated kube-client in an existing project to v0.94.0, and got the compilation errors error[E0432]: unresolved import `hyper_rustls::FixedServerNameResolver` and error[E0599]: no method named `with_server_name_resolver` found for struct `HttpsConnectorBuilder` in the current scope.

Solution

This struct and method were introduced in hyper-rustls v0.27.1, so I bumped the minimum dependency version accordingly.

@clux
Copy link
Member

clux commented Sep 9, 2024

Nice catch. Thank you. If you are able to do the do the DCO thing, i'll get out a patch later.

@clux clux added the changelog-fix changelog fix category for prs label Sep 9, 2024
@clux clux added this to the 0.94.1 milestone Sep 9, 2024
Signed-off-by: David Cook <dcook@divviup.org>
@divergentdave divergentdave force-pushed the hyper-rustls-min-version branch from 9dcfb7d to a59558a Compare September 9, 2024 15:22
@clux clux merged commit 3179e57 into kube-rs:main Sep 9, 2024
16 checks passed
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.3%. Comparing base (b3e9944) to head (a59558a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1575   +/-   ##
=====================================
  Coverage   75.3%   75.3%           
=====================================
  Files         82      82           
  Lines       7323    7323           
=====================================
  Hits        5511    5511           
  Misses      1812    1812           

@clux
Copy link
Member

clux commented Sep 9, 2024

Published 0.94.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-fix changelog fix category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants