Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade k8s-openapi to 0.22 and bump MK8SV to 1.25 #1485

Merged
merged 5 commits into from
May 6, 2024
Merged

Conversation

clux
Copy link
Member

@clux clux commented May 4, 2024

Propagating the new k8s-openapi release, which as usual requires a few propagating steps and a new minor release. Will do a release after merging this.

cargo upgrade -p k8s-openapi -i
just bump-k8s

Trivial chores to make it work as intended:

  • shifted one integer in the justfile recipe down to get it to give me the right MK8SV (otherwise it gave me 1.26).
  • k3s alignment in CI (auto-bump picked a tag in coverage that didn't exist, and usual action takes minor versions)

clux added 3 commits May 4, 2024 22:11
Signed-off-by: clux <sszynrae@gmail.com>
weirdly it tried to increment two versions which is wrong

Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux added this to the 0.91.0 milestone May 4, 2024
@clux clux added the changelog-change changelog change category for prs label May 4, 2024
clux added 2 commits May 4, 2024 22:33
Signed-off-by: clux <sszynrae@gmail.com>
Signed-off-by: clux <sszynrae@gmail.com>
Copy link

codecov bot commented May 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9%. Comparing base (96053fd) to head (08a4303).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1485     +/-   ##
=======================================
+ Coverage   74.1%   74.9%   +0.8%     
=======================================
  Files         78      78             
  Lines       6801    6801             
=======================================
+ Hits        5037    5091     +54     
+ Misses      1764    1710     -54     

see 2 files with indirect coverage changes

@clux clux marked this pull request as ready for review May 4, 2024 22:05
@clux clux requested a review from a team May 5, 2024 18:46
@clux
Copy link
Member Author

clux commented May 6, 2024

Going to send this through to reduce confusion w.r.t. k8s-openapi incompatibilities and release 0.91

@clux clux merged commit 51759b4 into main May 6, 2024
18 checks passed
@clux clux deleted the k8s-openapi22 branch May 6, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-change changelog change category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant