Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace reqwest ? #78

Closed
davidB opened this issue Oct 21, 2019 · 3 comments
Closed

replace reqwest ? #78

davidB opened this issue Oct 21, 2019 · 3 comments

Comments

@davidB
Copy link
Contributor

davidB commented Oct 21, 2019

Are you open to a PR to try to remove reqwest (very bloat in number of dependency) ?

I think with something like https://crates.io/crates/http_req + rust-tls.

@clux
Copy link
Member

clux commented Oct 21, 2019

it's unlikely we want to change reqwest itself because that's a lot of functionality to replace, and we would need a lot better arguments than dependency bloat. Particularly since it's unlikely you'll escape the biggest dependencies like k8s-openapi and tokio anyway.

however, want to upgrade reqwest to support:

@davidB
Copy link
Contributor Author

davidB commented Oct 21, 2019

I agree k8s-openapi is the longer to build, but tokio will be removed with reqwest, as lightweight http client doesn't use it.

@davidB
Copy link
Contributor Author

davidB commented Oct 21, 2019

Ok so wait for await/async stabilization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants