Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose shortnames of CustomResource derive #641

Merged
merged 2 commits into from
Oct 5, 2021

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Oct 5, 2021

@nightkr nightkr added the derive kube-derive proc_macro related label Oct 5, 2021
@nightkr nightkr requested a review from clux October 5, 2021 12:02
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@nightkr
Copy link
Member Author

nightkr commented Oct 5, 2021

Oh right, need to start remembering to --signoff.. :P

@nightkr nightkr force-pushed the feature/crdext-shortname branch from 1b10df7 to 7aa48a4 Compare October 5, 2021 13:37
Signed-off-by: Teo Klestrup Röijezon <teo@nullable.se>
@nightkr nightkr force-pushed the feature/crdext-shortname branch from 7aa48a4 to 4866f15 Compare October 5, 2021 13:38
@nightkr nightkr merged commit b13c619 into kube-rs:master Oct 5, 2021
@nightkr nightkr deleted the feature/crdext-shortname branch October 5, 2021 13:40
@lfrancke
Copy link
Contributor

lfrancke commented Oct 5, 2021

That was fast! I didn't even have time to look at it :)
Thank you!

I had something started as well but yours is much better.
There are a few other things that are not exposed yet IIRC...might make sense for completeness sake to do those as well.

@nightkr
Copy link
Member Author

nightkr commented Oct 6, 2021

Yeah.. figured we can get to those as the need arises.

@clux
Copy link
Member

clux commented Oct 9, 2021

Released in 0.61.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
derive kube-derive proc_macro related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create PR in kube-rs to add shortname & other accessors to CustomResourceExt
3 participants