update kfservice status URL #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @yuzisun Could you please help to take a look? Thanks. |
|
Sounds good to me, want to hear @johnugeorge’s thoughts. |
|
Looks good to me. |
|
/lgtm |
|
Discussed with Ellis we can always extend if needed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuzisun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ellistarn
pushed a commit
to ellistarn/kfserving
that referenced
this pull request
Jul 28, 2020
rafvasq
pushed a commit
to rafvasq/kserve
that referenced
this pull request
Jul 21, 2023
#### Motivation The file containing the default configuration for the ModelMesh Controller is called `config-defaults.yaml`, which resides in a directory also called `config-defaults.yaml` as pointed out by @adrwong-lora in issue kserve#205 ``` /etc/model-serving/config-defaults.yaml/config-defaults.yaml ``` #### Modifications Change `mountPath` from `/etc/model-serving/config-defaults.yaml` to `/etc/model-serving/config/default` #### Result The file containing the default configuration file after this fix: ``` /etc/model-serving/config/default/config-defaults.yaml ``` Which more closely reflects the path of the [`config-defaults.yaml`](https://github.com/kserve/modelmesh-serving/blob/main/config/default/config-defaults.yaml) file in the `modelmesh-serving` repository: ``` config/default/config-defaults.yaml ``` Resolves kserve#205 /cc @njhill /fyi @adrwong-lora Signed-off-by: Christian Kadner <ckadner@us.ibm.com>
ruivieira
pushed a commit
to ruivieira/kserve
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Background: After introducing
apis.URLto status in the #251, we have to create this hack since that struct is deep in go standard net library and we can not add openapi annotation, @yuzisun suggests creating our simplified URL struct. After investigation, I think that's better to back tostringfor URL since if we ceate our URL struct, that's hard to assign with net.url (cannot sure no issue in the future). And there is a String function in the knative.dev/pkg/apis.URL, we can use that and transfer to string for kfservice. That's good enough for kfservice.See more details in the #272
This change is