Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Knative release 0.7.1 #251

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Upgrade to Knative release 0.7.1 #251

merged 1 commit into from
Jul 17, 2019

Conversation

johnugeorge
Copy link
Contributor

@johnugeorge johnugeorge commented Jul 17, 2019

knative is upgraded to version 0.7.1 while kfserving uses knative v1alpha1 version. Corresponding changes are incorporated

knative 0.7.1 has to be installed(uses v1alpha1 api by default)

This is a subset of #238 changes
Related: knative/serving#4533


This change is Reviewable

@johnugeorge
Copy link
Contributor Author

/assign @ellis-bigelow
/assign @yuzisun

@ellistarn
Copy link
Contributor

Nice work. Bummer we'll need to re-migrate, but the effort should be smaller.

/lgtm
Will leave approve to @yuzisun .

@yuzisun
Copy link
Member

yuzisun commented Jul 17, 2019

Awesome work!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yuzisun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 55178f0 into kserve:master Jul 17, 2019
Tomcli added a commit to Tomcli/kfserving that referenced this pull request Jul 22, 2019
* Created Cloud Build Triggers for automated image building. (kserve#185)

* Added cloud build

* Created Cloud Build Triggers for automated image building. Script must be run manually. Build triggers are in alpha.

* Added pytorch and alibi builders

* Added model initializer builder

* Added build contexts

* Renamed script

* Fixed executor build

* Upgrade to Knative release 0.7.1 (kserve#251)

* Remove NVCR.io workaround (kserve#254)

Now that we have knative 0.7 the workaround is no longer needed!

* More TF2OpenAPI Unit Tests (kserve#248)

* Test with real models

* Resolve non-determinism in array matching

* Make OpenAPI restrictions more strict

* disallow additional properties in req body that aren't specified in
OpenAPI

* Update unit tests to be more restrictive

* Add generator unit test

* Add generator tests

* Add JSON extension to spec files for highlighting

* Move utils to kfserving utils

* Fix formatting

* Organize utils types into separate file

* TF2OpenAPI E2E Tests (kserve#247)

* Add E2E tests for CLI

* Add JSON extension to golden files for highlighting

* Abstract out JSON expect statements for reuse

* Templatize tests

* kfservice python sdk package

* Update README.md
ellistarn pushed a commit to ellistarn/kfserving that referenced this pull request Jul 28, 2020
terrytangyuan pushed a commit to terrytangyuan/kserve that referenced this pull request May 13, 2024
…ent-updates/kserve-storage-initializer-28

Update kserve-storage-initializer-28 to d9fc3b5
ruivieira pushed a commit to ruivieira/kserve that referenced this pull request Oct 1, 2024
set disableIngressCreation to true in odh overlay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants