Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid / expired LICENSE #141

Open
tj-smith47 opened this issue Jan 15, 2025 · 2 comments
Open

Invalid / expired LICENSE #141

tj-smith47 opened this issue Jan 15, 2025 · 2 comments
Assignees

Comments

@tj-smith47
Copy link

Describe the bug
The MIT license in this repo is outdated (and/or possibly improperly formatted for the given license type), causing Snyk security PR checks against open source licenses to fail when adding or modifying this gem in a Gemfile.lock.

To Reproduce
Set up Snyk open-source license scanning in an organization or repo, then add this gem to a Gemfile.lock. Anyone who uses those (or similar open source) scanning tools would be affected.

Expected behavior
The security team at a company that enforces open-source license scanning compliance approves use of this gem.

To fix
Add a new MIT license, or update the existing one so that it isn't expired and remove the extra blank line at the beginning. The latter may not matter, just a difference I noticed from other valid MIT licenses.

@ssinghi ssinghi self-assigned this Jan 27, 2025
@ssinghi
Copy link

ssinghi commented Jan 27, 2025

Hi @tj-smith47 I removed the extra blank line at top, can you confirm it is fine now?

@tj-smith47
Copy link
Author

@ssinghi Thanks for making that change! I believe we've determined that this is either a Snyk or configuration issue on our end. However I did notice that when I go view the LICENSE in GitHub, I still don't see the "License is valid message" at the top like I normally would in other repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants