Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not appear persistent #5

Open
stefanpenner opened this issue Jul 29, 2016 · 3 comments
Open

does not appear persistent #5

stefanpenner opened this issue Jul 29, 2016 · 3 comments

Comments

@stefanpenner
Copy link

The TS linter appears sufficiently costly, that enabling the persistent mode would be a nice startup improvement.

@kratiahuja
Copy link
Owner

@stefanpenner Do you mean using broccoli-persistent-filter? I thought I am extending from that. I am still new to broccoli stuff and this was my first broccoli plugin so maybe I am not understanding this issue completely :-)

@stefanpenner
Copy link
Author

stefanpenner commented Aug 1, 2016

@kratiahuja ya, its confusing (most likely the author of persistent-filter itself fault)

TL;DR persistent-filter provides a more efficient and stable filter subclass, but the persistent part is opt-in. This is because cache keys are hard, and require extra thought.

https://github.com/stefanpenner/broccoli-persistent-filter#persistent-cache may help, let me know if it does not I would love some input on how to improve the docs.

@kratiahuja
Copy link
Owner

Aah ok, this makes sense now. I didn't realize it was an opt-in. I'll read through the docs. I'll look into this sometime this week :) . Thank you @stefanpenner !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants