Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests not getting updated when tslint.json is updated #15

Open
kratiahuja opened this issue Jan 24, 2017 · 4 comments
Open

Tests not getting updated when tslint.json is updated #15

kratiahuja opened this issue Jan 24, 2017 · 4 comments

Comments

@kratiahuja
Copy link
Owner

From @Turbo87 in #12

one issue I noticed though is that when I change the tslint.json file the tests are apparently not updated, but that seems to be a different issue and unrelated to fixing the extends feature.

@rwjblue
Copy link
Collaborator

rwjblue commented Jan 24, 2017

In general, changing config will require a restart of the build (this is true of package.json, .eslintrc.js, ember-cli-build.js, etc).

@Turbo87
Copy link

Turbo87 commented Jan 25, 2017

@rwjblue that might be the current state, but is there no way to fix that?

@rwjblue
Copy link
Collaborator

rwjblue commented Jan 25, 2017

It is currently not possible to watch things in the root of the project because changes in tmp would also be watched and cause infinite rebuild loop. Using watchman helps a little bit, because it suppresses the rebuild triggered by ./tmp changes (since we have a config file that ignores tmp and dust), but watchman isn't required (or well supported for some of our platforms).

tldr; upgrading to broccoli@1 unblocks things like this (conceptually), but it's still pretty difficult to reason about

@rwjblue
Copy link
Collaborator

rwjblue commented Jan 25, 2017

It's probably possible to do a one off solution for this particular case (basically forcing a content comparison of the tslint.json for every build), but I wouldn't trigger a rebuild upon changing the lint config (it would only allow a subsequent watched file change to pull in the new config).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants