fix: translate_span: Make assert more specific #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, the assert in translate_span would now allow for a duration_ms of `0`. This usually makes sense, but what the assert seems to actually be for, is to check whether duration_ms has been set (that is, somebody has run .finished() on the Span). This fixes the assert to check that duration_ms is not None, which has the nice side-effect that it allows for Spans to be created+finished in a unittest setting where freezegun.freeze_time() is activated.
|
🤢 I thought we had better taste than this...
|
torarvid
changed the title
torarvid
pushed a commit
that referenced
this pull request
Mar 11, 2025
🤖 I have created a release *beep* *boop* --- ## [5.2.1](5.2.0...5.2.1) (2025-03-11) ### Bug Fixes * translate_span: Make assert more specific ([#370](#370)) ([1145be0](1145be0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the assert in translate_span would now allow for a duration_ms of
0. This usually makes sense, but what the assert seems to actually be for, is to check whether duration_ms has been set (that is, somebody has run .finished() on the Span).This fixes the assert to check that duration_ms is not None, which has the nice side-effect that it allows for Spans to be created+finished in a unittest setting where freezegun.freeze_time() is activated.