Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

launcher grpc methods don't time out #159

Closed
groob opened this issue Sep 26, 2017 · 0 comments
Closed

launcher grpc methods don't time out #159

groob opened this issue Sep 26, 2017 · 0 comments
Assignees
@zwass

Comments

@groob
Copy link
Contributor

groob commented Sep 26, 2017

If the launcher sends a gRPC request to the server, but the server just sleeps and never responds, the launcher is stuck. Possibly related to #134.

Repro:

I created a go server with time.Sleep(1 * time.Hour) for every RPC method.
https://gist.github.com/groob/8f44fc01581bd9a92cf95fe7a86ae9a7

Then, I launched the server with:

sudo ./build/launcher -root_directory /var/kolide/debug -hostname localhost:9090 -enroll_secret_path /etc/kolide/secret -insecure_grpc -debug
@groob groob added the Bug label Sep 26, 2017
@groob groob mentioned this issue Sep 26, 2017
Merged
groob added a commit that referenced this issue Sep 27, 2017
@groob
add per-request timeouts to endpoints (#162)
32a2a68 
Adds a timeout to the request context for all go-kit endpoints.

Fixes #159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zwass zwass

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zwass @groob