Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple Istio and Knative installation between test-infra and serving #675

Closed
adrcunha opened this issue Apr 4, 2019 · 3 comments
Closed
Assignees

Comments

@adrcunha
Copy link
Contributor

adrcunha commented Apr 4, 2019

knative/serving has its own serving installation function (https://github.com/knative/serving/blob/b5ae99b62303ff31437ba49b7fe48a664a74bdae/test/e2e-common.sh#L123), while all other repos use a standard function from knative/test-infra (

function start_latest_knative_serving() {
).

If these two functions are out-of-sync, updates to knative/serving might block E2E tests (presubmits and CI) in all the other repos (e.g., #674).

@adrcunha
Copy link
Contributor Author

adrcunha commented Apr 4, 2019

One simple (short-term?) solution would be adding an extra E2E test to serving that uses the function in library.sh to bring up serving.

@jessiezcc
Copy link
Contributor

Pls sync up with @adrcunha on short term vs long term preference.

@adrcunha
Copy link
Contributor Author

With Knative Serving 0.6 this is now obsolete, as installing it is now a single yaml. Closing as obsolete.

Cynocracy pushed a commit to Cynocracy/test-infra that referenced this issue Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants