Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Knative Serving installation function is broken #674

Closed
adrcunha opened this issue Apr 4, 2019 · 4 comments
Closed

Default Knative Serving installation function is broken #674

adrcunha opened this issue Apr 4, 2019 · 4 comments
Assignees
@nbarthwal

Comments

@adrcunha
Copy link
Contributor

adrcunha commented Apr 4, 2019

knative/serving#3353 updated Knative Serving to use Istio 1.1.1, and that required a small change in the way Istio CRDs are installed.

However, the PR above didn't update the standard Knative Serving installation function, used by all the other repos to bring up the SUT (

test-infra/scripts/library.sh

Line 302 in 0125a23

function start_latest_knative_serving() {
)

#672 updates the function above. This now needs to be replicated to the other repos, in order to unbreak their integration and CI tests.

/assign @nbarthwal
@adrcunha adrcunha mentioned this issue Apr 4, 2019
Closed
@adrcunha
Copy link
Contributor Author

adrcunha commented Apr 4, 2019

Filed #675 for pursuing a long-term solution and preventing this from reoccurring.

@adrcunha
Copy link
Contributor Author

adrcunha commented Apr 4, 2019

@tcnghia FYI

@adrcunha
Copy link
Contributor Author

adrcunha commented Apr 4, 2019

Also, when serving gets test-infra update, the copy of wait_until_batch_job_complete() in e2e-common.sh can be removed.

@nbarthwal
Copy link
Contributor

nbarthwal commented Apr 4, 2019 via email

@adrcunha adrcunha mentioned this issue May 31, 2019
Closed
Cynocracy pushed a commit to Cynocracy/test-infra that referenced this issue Jun 13, 2020
@chaodaiG @adrcunha @knative-prow-robot
Add cluster deletion funciton (knative#674)
5563401 
* Add cluster deletion funciton

* Apply suggestions from code review

Co-Authored-By: Adriano Cunha <35786489+adrcunha@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nbarthwal nbarthwal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adrcunha @jessiezcc @nbarthwal