Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add /var/log volume mount only when EnableVarLogCollection is true #9683

Merged
merged 3 commits into from
Oct 13, 2020

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Oct 2, 2020

Fixes #3809

Contributes to #7881

Proposed Changes

  • add /var/log volume mount only when EnableVarLogCollection is true

Release Note

We only mount a volume at /var/log if the operator has enabled log collection
Runtime contract /var/log requirement has changed from MUST to MAY

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Oct 2, 2020
@dprotaso
Copy link
Member Author

dprotaso commented Oct 2, 2020

/assign @JRBANCEL

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 2, 2020
@knative-prow-robot knative-prow-robot added area/API API objects and controllers approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 2, 2020
@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #9683 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9683      +/-   ##
==========================================
+ Coverage   88.09%   88.12%   +0.03%     
==========================================
  Files         176      176              
  Lines        8424     8432       +8     
==========================================
+ Hits         7421     7431      +10     
+ Misses        758      757       -1     
+ Partials      245      244       -1     
Impacted Files Coverage Δ
pkg/reconciler/revision/resources/deploy.go 100.00% <100.00%> (ø)
pkg/webhook/podspec_dryrun.go 75.86% <0.00%> (ø)
pkg/apis/config/defaults.go 91.80% <0.00%> (+0.27%) ⬆️
pkg/reconciler/configuration/configuration.go 89.16% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9076105...942aea6. Read the comment docs.

@knative-prow-robot knative-prow-robot added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Oct 3, 2020
@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:

pkg/reconciler/autoscaling/kpa.TestReconcileDeciderCreatesAndDeletes

@dprotaso
Copy link
Member Author

dprotaso commented Oct 3, 2020

/retest

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso dprotaso added this to the 0.19.x milestone Oct 5, 2020
Copy link
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)

@dprotaso dprotaso force-pushed the runtime-var-log-flag branch from 410616a to 942aea6 Compare October 5, 2020 13:24
@JRBANCEL
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2020
@knative-prow-robot knative-prow-robot merged commit 2dcb900 into knative:master Oct 13, 2020
@dprotaso dprotaso deleted the runtime-var-log-flag branch February 1, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/test-and-release It flags unit/e2e/conformance/perf test issues for product features cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

volume mount break Pod startup
6 participants