-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add /var/log volume mount only when EnableVarLogCollection is true #9683
add /var/log volume mount only when EnableVarLogCollection is true #9683
Conversation
/assign @JRBANCEL |
Codecov Report
@@ Coverage Diff @@
## master #9683 +/- ##
==========================================
+ Coverage 88.09% 88.12% +0.03%
==========================================
Files 176 176
Lines 8424 8432 +8
==========================================
+ Hits 7421 7431 +10
+ Misses 758 757 -1
+ Partials 245 244 -1
Continue to review full report at Codecov.
|
The following jobs failed:
Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:
|
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Produced via:
prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github | grep -v docs/cmd/)
410616a
to
942aea6
Compare
/lgtm |
Fixes #3809
Contributes to #7881
Proposed Changes
Release Note