Do not create wildcard certs when autoTLS is disabled #5636
Conversation
|
@nak3: GitHub didn't allow me to request PR reviews from the following users: rmoe. Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
knative-prow-robot
added
the
size/XS
There was a problem hiding this comment.
@nak3: 0 warnings.
In response to this:
Proposed Changes
cert-manager is not setup and cert-manger is not setup. Due to that, we
always get cert creation error whenever creating a new namespace.To fix it, this patch changes to stop creating wildcard certs when
autoTLS is disabled./lint
Fixes #5635
Release Note
nscert does not create wildcard cert when autoTLS is disabled.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Currently nscert tries to create wildcard certs even though certmanager is not setup and certmanger is not setup. Due to that, we always get cert creation error whenever creating a new namespace. To fix it, this patch changes to stop creating wildcard certs when autoTLS is disabled.
nak3
force-pushed
the
autotls-nscert
branch
from
a02170a to
46fd6c8
Compare
nak3
changed the title
knative-prow-robot
added
size/M
|
The following is the coverage report on pkg/.
|
|
The following jobs failed:
Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests: |
|
/test pull-knative-serving-unit-tests |
There was a problem hiding this comment.
The code makes sense to me. Not qualified to LGTM though.
/assign @ZhiminXiang
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes, nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
/lgtm |
|
/test pull-knative-serving-unit-tests |
Proposed Changes
Currently nscert tries to create wildcard certs even though
cert-manager is not setup and cert-manger is not setup. Due to that, we
always get cert creation error when creating a new namespace.
To fix it, this patch changes to stop creating wildcard certs when
autoTLS is disabled.
/lint
Fixes #5635
Release Note
/cc @rmoe @ZhiminXiang @tcnghia