Update our dependency on K8s libs to 1.15.3 #5570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
do-not-merge/hold
knative-prow-robot
added
area/API
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
knative-prow-robot
requested review from
dprotaso,
greghaynes,
josephburnett,
markusthoemmes,
mdemirhan,
srinivashegde86 and
yanweiguo
mattmoor
commented
Sep 17, 2019
| @@ -63,7 +63,8 @@ func NewMetricProvider(metricClient MetricClient) *MetricProvider { | |||
| } | |||
|
|
|||
| // GetMetricByName implements the interface. | |||
| func (p *MetricProvider) GetMetricByName(name types.NamespacedName, info provider.CustomMetricInfo) (*cmetrics.MetricValue, error) { | |||
| func (p *MetricProvider) GetMetricByName(name types.NamespacedName, info provider.CustomMetricInfo, | |||
| metricSelector labels.Selector) (*cmetrics.MetricValue, error) { | |||
There was a problem hiding this comment.
LMK what the best way to incorporate this would be?
There was a problem hiding this comment.
I've looked through the upstream changes and it seems absolutely fine for us to just not implement it at all right now.
mattmoor
force-pushed
the
update-client-go
branch
2 times, most recently
from
5e0b033 to
3857f1e
Compare
mattmoor
force-pushed
the
update-client-go
branch
2 times, most recently
from
32fda97 to
1595bcb
Compare
mattmoor
force-pushed
the
update-client-go
branch
from
1595bcb to
388137b
Compare
mattmoor
force-pushed
the
update-client-go
branch
from
388137b to
ffc48f9
Compare
|
/test pull-knative-serving-integration-tests |
mattmoor
force-pushed
the
update-client-go
branch
from
ffc48f9 to
4bfa6ed
Compare
|
/lgtm |
|
This needs the change from @JRBANCEL to land first |
|
The following jobs failed due to test flakiness:
Failed non-flaky tests preventing automatic retry of pull-knative-serving-integration-tests: |
With a minimum K8s version of 1.14 (starting in 0.10), 1.15.3 puts us in the center of the +/-1 version window of support. /hold This depends on a number of upstream PRs to land, including in the K8s incubator.
mattmoor
force-pushed
the
update-client-go
branch
from
4bfa6ed to
cceee36
Compare
|
/lgtm |
|
The following is the coverage report on pkg/.
|
|
/hold cancel |
knative-prow-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a minimum K8s version of 1.14 (starting in 0.10), 1.15.3 puts us in the center of the +/-1 version window of support.
/hold
This depends on a number of upstream PRs to land, including in the K8s incubator.